Code review

[tshemsedinov]

1. Long try blocks are dangerous, they can generate multiple exceptions in different places and you can't localize it with catch, only by eyes or if-statement logic:

   cyberchef/src/client/src/app/actions/account/registerUser.js

   Lines 6 to 30 in 63d42b0

   	try {
   	const headers = {
   	'Content-Type': 'application/json',
   	};
   	const data = {
   	email, password, username: email
   	};
   	const response = await fetch('api/auth/registration', {
   	method: 'POST',
   	headers,
   	body: JSON.stringify(data),
   	});
   	if (!response.ok) {
   	return rejectWithValue(await response.json());
   	}
   	return {
   	...await response.json(),
   	};
   	} catch (error) {
   	if (error.response && error.response.data.message) {
   	return rejectWithValue(error.response.data.message);
   	} else {
   	return rejectWithValue(error.message);
   	}
   	}

   and

   cyberchef/src/server/repositories/recipe.repository.ts

   Lines 43 to 59 in 04b67ae

   	try {
   	const deleteFavRecipes = this.prisma.favourite_recipes.deleteMany({
   	where: {
   	recipe_id: parseInt(recipeId),
   	},
   	});
   	const deleteRecipe = this.prisma.recipes.delete({
   	where: {
   	id: parseInt(recipeId),
   	},
   	});
   	await this.prisma.$transaction([deleteFavRecipes, deleteRecipe]);
   	return true;
   	} catch (error) {
   	console.error(error);
   	return false;
   	}

   and other places
2. Using JWT you must understand all problems and security issues it can bring and estimate advantages and disadvantages. Have you?
3. Following code blocks have multiple duplications, think how to combine it with higher program abstractions, you have multiple such files: https://github.com/readme-experts/cyberchef/blob/63d42b070137b56913308143a0b6d6a308f3adec/src/client/src/app/actions/account/loginUser.js or https://github.com/readme-experts/cyberchef/blob/63d42b070137b56913308143a0b6d6a308f3adec/src/client/src/app/actions/account/deleteUserRecipe.js
4. Hardcoded port number https://github.com/readme-experts/cyberchef/blob/63d42b070137b56913308143a0b6d6a308f3adec/src/client/src/setupProxy.js and password length:

   cyberchef/src/client/src/features/ValidationError.js

   Lines 13 to 14 in 856b63d

   	if (data.password.length < 8) validationErrors.push(new ValidationError(
   	'password', 'Password is shorter than 8 symbols',

Overall codebase looks fine