Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Screenreader does not announce the number of listed versions #953

Open
jonels-msft opened this issue Jun 24, 2020 · 1 comment · May be fixed by #1164
Open

Screenreader does not announce the number of listed versions #953

jonels-msft opened this issue Jun 24, 2020 · 1 comment · May be fixed by #1164
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@jonels-msft
Copy link
Contributor

Problem

When the version picker box is open, the screenreader is unable to determine the number of version list items. Thus a user cannot determine their progress through the list.
https://github.com/readthedocs/sphinx_rtd_theme/blob/5ba05cd1faa2ce22723b437d2b1d0f265dfcd225/sphinx_rtd_theme/versions.html

Reproducible Project

https://docs.citusdata.com/en/stable/

Error Logs/Results

Here is a video demonstrating the problem: https://www.youtube.com/watch?v=-OvNZkY7-gA

Expected Results

The version picker should conform to WCAG 1.3.1 and help the screenreader announce the number of list items.

Environment Info

  • Python Version: 3.7.7
  • Sphinx Version: 1.4.9
  • RTD Theme Version: 0.2.4
@stsewd
Copy link
Member

stsewd commented Oct 7, 2020

Not sure what would be the solution for this. They are inside a definition list, so I guess the solution is something else.

@stsewd stsewd added Improvement Minor improvement to code Needed: design decision A core team decision is required labels Oct 7, 2020
@jonels-msft jonels-msft linked a pull request Jun 15, 2021 that will close this issue
Open
@MarcelRaschke MarcelRaschke mentioned this issue Aug 20, 2022
Open
@snyk-bot snyk-bot mentioned this issue Aug 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use semantic markup in flyout jonels-msft/sphinx_rtd_theme_citus
2 participants
@stsewd @jonels-msft