Report a distinct error code for sync connection timeouts #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-wb
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
LGTM - the two failures are known issues (audit: due to a new feature in baas server, compensating writes: occasionally fails due to missing MARK response)
Two tiny comments - we haven't really established a policy about adding new values to error_codes.h since we're not sure if anyone is relying on the numeric values (hopefully not), but this change should be fine.
Comment on lines
+76
to
+85
| RLM_ERR_SYNC_CONNECT_TIMEOUT = 1035, | ||
| RLM_ERR_SYNC_INVALID_SCHEMA_CHANGE = 1036, | ||
| RLM_ERR_SYNC_PERMISSION_DENIED = 1037, | ||
| RLM_ERR_SYNC_PROTOCOL_INVARIANT_FAILED = 1038, | ||
| RLM_ERR_SYNC_PROTOCOL_NEGOTIATION_FAILED = 1039, | ||
| RLM_ERR_SYNC_SERVER_PERMISSIONS_CHANGED = 1040, | ||
| RLM_ERR_SYNC_USER_MISMATCH = 1041, | ||
| RLM_ERR_TLS_HANDSHAKE_FAILED = 1042, | ||
| RLM_ERR_WRONG_SYNC_TYPE = 1043, | ||
| RLM_ERR_SYNC_WRITE_NOT_ALLOWED = 1044, |
There was a problem hiding this comment.
Hopefully no one is relying on the actual numeric values...
The same error code was used for both timeouts and other connection failures, and the error reported always had an empty message.
tgoyne
force-pushed
the
tg/sync-timeout-error
branch
from
fbfb176
to
eba867f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same error code was used for both timeouts and other connection failures, and the error reported always had an empty message.