Fix membership form for December

Author: rebkwok

booking/forms.py

@@ -378,31 +378,35 @@ def __init__(self, *args, **kwargs):
 
         # if current date is <25th, give option to start membership from this month as well as next monht
         today = datetime.today()
+        if today.month == 12:
+                next_month = 1
+        else:
+            next_month = today.month + 1
         if today.day < 25 and not has_cancelled_current_membership: 
             # choice values refer to whether to backdate or not
-            choices = ((1, calendar.month_name[today.month]), (0, calendar.month_name[today.month + 1]))
+            choices = ((1, calendar.month_name[today.month]), (0, calendar.month_name[next_month]))
             initial = None
             help_text = (
                 f"Note that if you choose to start your membership in the current month ({calendar.month_name[today.month]}), "
                 f"payment will be taken immediately, and you will have the entire {calendar.month_name[today.month]} membership allowance to "
                 f"use until the end of the month. Payment will be taken again on the 25th {calendar.month_name[today.month]} "
-                f"for {calendar.month_name[today.month + 1]}'s membership, and on the 25th of each month thereafter."
+                f"for {calendar.month_name[next_month]}'s membership, and on the 25th of each month thereafter."
             )
         else:
             # no option to backdate if it's 25th or later in the month, only show option for next month
-            choices = ((0, calendar.month_name[today.month + 1]),)
+            choices = ((0, calendar.month_name[next_month]),)
             initial = 0
             if today.day >= 25:
                 help_text = (
-                    f"Payment will be taken immediately for {calendar.month_name[today.month + 1]}'s membership. You will be able to use this membership "
-                    f"immediately to book for classes scheduled in {calendar.month_name[today.month + 1]}. Payment will be taken on the 25th of each "
+                    f"Payment will be taken immediately for {calendar.month_name[next_month]}'s membership. You will be able to use this membership "
+                    f"immediately to book for classes scheduled in {calendar.month_name[next_month]}. Payment will be taken on the 25th of each "
                     "month thereafter, for the following month's membership."
                 )
             else:
                 help_text = (
-                    f"Payment will be taken on 25th {calendar.month_name[today.month]} for {calendar.month_name[today.month + 1]}'s membership. "
+                    f"Payment will be taken on 25th {calendar.month_name[today.month]} for {calendar.month_name[next_month]}'s membership. "
                     "You will be able to use this membership immediately to book for classes scheduled in "
-                    f"{calendar.month_name[today.month + 1]}. Payment will be taken on the 25th of each "
+                    f"{calendar.month_name[next_month]}. Payment will be taken on the 25th of each "
                     "month thereafter, for the following month's membership."
                 )
 

booking/tests/test_membership_views.py

@@ -52,6 +52,23 @@ def test_membership_create_get(client, seller, configured_user):
     assert form.fields["backdate"].choices == [(1, "February"), (0, "March")]
 
 
+@pytest.mark.freeze_time("2024-12-10")
+@patch("booking.models.membership_models.StripeConnector", MockConnector)
+def test_membership_create_get_end_of_year(client, seller, configured_user):
+    client.force_login(configured_user)
+    m1 = baker.make(Membership, name="m1", active=True)
+    m2 = baker.make(Membership, name="m2", active=True)
+    m3 = baker.make(Membership, name="m3", active=False)
+    baker.make(Membership, name="m4", active=True)
+    for m in [m1, m2, m3]:
+        baker.make(MembershipItem, membership=m)
+    resp = client.get(create_url)
+    assert resp.status_code == 200
+    form = resp.context_data["form"]
+    assert set(form.fields["membership"].queryset) == {m1, m2}
+    assert form.fields["backdate"].choices == [(1, "December"), (0, "January")]
+
+
 @pytest.mark.freeze_time("2024-02-25 10:00")
 @patch("booking.models.membership_models.StripeConnector", MockConnector)
 def test_membership_create_after_25th_of_month(client, seller, configured_user):