-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve and Standardize Error Handling and Logging Strategy #6
Comments
let me handle this |
Hey @AbdulRashidReshamwala I can see the first 2 major goals are already implemented I can observe in the codebase there is already a custom handling mechanism and most of all files have a logger for log extra info, I can observe there might be need for custom error types and improve existing error message. So do you want me to go into that or maybe I am entirely wrong with my observation and we need to achieve all the listed goals |
Hi @Girishbari. We have moved to a custom implementation of logging. We are no longer using pino. Currently across all the files we are using info logs. We need to segregate these logs based on the type of information we want to convey to the user. New goals are as follows
|
Yeah this can be done |
hi @Kushal7788 I revalidated both points I have added proper logs message type wherever required and there are already good error messages provided. Which conveys proper suggestion and error message and also provides most probable solution although I made few tweaks here and there |
Hi @Kushal7788, there are validation methods for respective public methods then why codebase is only using |
Improve and Standardize Error Handling and Logging Strategy
Description
While we already use pino for logging in our SDK, our error handling approach is inconsistent across the codebase. We need to standardize our error handling and improve our use of the existing logging system to enhance debugging, error reporting, and overall reliability of the SDK. Some error messages donot provide the entire context on what caused the issue and what action user to take to solve the issue.
Goals
Current State
We currently use pino for logging:
The text was updated successfully, but these errors were encountered: