From 3901b14fa6b2938477da43d1ee33328571e7d2f0 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Fri, 26 Jan 2024 20:29:37 +0100 Subject: [PATCH] Publish code examples --- app/Controller/UserController.php | 2 +- .../src/Rector/UseRequestRequestGetRector.php | 15 ++++++++------- 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/app/Controller/UserController.php b/app/Controller/UserController.php index 1a05b84..bd40862 100644 --- a/app/Controller/UserController.php +++ b/app/Controller/UserController.php @@ -12,7 +12,7 @@ final class UserController extends AbstractController { public function registerUser(Request $request): Response { - $username = $request->request->get('username'); + $username = $request->get('username'); $hasher = $this->container->get('password_hasher'); diff --git a/utils/rector/src/Rector/UseRequestRequestGetRector.php b/utils/rector/src/Rector/UseRequestRequestGetRector.php index e11fa5f..e356306 100644 --- a/utils/rector/src/Rector/UseRequestRequestGetRector.php +++ b/utils/rector/src/Rector/UseRequestRequestGetRector.php @@ -9,12 +9,12 @@ use PhpParser\Node\Expr\PropertyFetch; use PHPStan\Type\ObjectType; use Rector\Rector\AbstractRector; -use SelectiveVarDump\SelectiveVarDumper; -use SelectiveVarDump\VarDumperConfig; use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; final class UseRequestRequestGetRector extends AbstractRector { + // crop-start + /** * @param MethodCall $node */ @@ -24,11 +24,6 @@ public function refactor(Node $node): ?Node return null; } - $varDumper = new SelectiveVarDumper(new VarDumperConfig([ - 'className', - ])); - echo $varDumper->dump($this->getType($node->var)) . "\n\n"; - if (! $this->isObjectType( $node->var, new ObjectType('Symfony\Component\HttpFoundation\Request') @@ -36,11 +31,17 @@ public function refactor(Node $node): ?Node return null; } + /* + * Make the original method call on the fetched `request` + * property instead: + */ $node->var = new PropertyFetch($node->var, 'request'); return $node; } + // crop-end + /** * @return array> */