From 234d7c92e587db8cc4c592e3de5706700883e7f6 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Thu, 20 Jun 2024 22:53:09 +0900 Subject: [PATCH] remove tests --- .../AutoImportTest.php | 28 ------ .../add_constructor_for_attribute.php.inc | 33 ------- .../Fixture/existing_constructor.php.inc | 48 ---------- .../Fixture/fixture.php.inc | 41 --------- .../Fixture/skip_added.php.inc | 22 ----- .../Fixture/skip_added_values.php.inc | 22 ----- .../do_not_repetitive_assign.php.inc | 90 ------------------- ...alizeDefaultEntityCollectionRectorTest.php | 28 ------ .../config/auto_import.php | 12 --- .../config/configured_rule.php | 10 --- .../Fixture/some_class.php.inc | 43 --------- .../Source/Entity/TrainingTerm.php | 10 --- ...opertyFromDoctrineCollectionRectorTest.php | 28 ------ .../config/configured_rule.php | 10 --- ...nitializeDefaultEntityCollectionRector.php | 2 - ...edPropertyFromDoctrineCollectionRector.php | 2 +- 16 files changed, 1 insertion(+), 428 deletions(-) delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/AutoImportTest.php delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/add_constructor_for_attribute.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/existing_constructor.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/fixture.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added_values.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/FixtureAutoImport/do_not_repetitive_assign.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/InitializeDefaultEntityCollectionRectorTest.php delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/auto_import.php delete mode 100644 rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/configured_rule.php delete mode 100644 rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Fixture/some_class.php.inc delete mode 100644 rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Source/Entity/TrainingTerm.php delete mode 100644 rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/TypedPropertyFromDoctrineCollectionRectorTest.php delete mode 100644 rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/config/configured_rule.php diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/AutoImportTest.php b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/AutoImportTest.php deleted file mode 100644 index 093c28be..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/AutoImportTest.php +++ /dev/null @@ -1,28 +0,0 @@ -doTestFile($filePath); - } - - public static function provideData(): Iterator - { - return self::yieldFilesFromDirectory(__DIR__ . '/FixtureAutoImport'); - } - - public function provideConfigFilePath(): string - { - return __DIR__ . '/config/auto_import.php'; - } -} diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/add_constructor_for_attribute.php.inc b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/add_constructor_for_attribute.php.inc deleted file mode 100644 index 833ed97d..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/add_constructor_for_attribute.php.inc +++ /dev/null @@ -1,33 +0,0 @@ - ------ -marketingEvents = new \Doctrine\Common\Collections\ArrayCollection(); - } -} - -?> diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/existing_constructor.php.inc b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/existing_constructor.php.inc deleted file mode 100644 index 71e2ea75..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/existing_constructor.php.inc +++ /dev/null @@ -1,48 +0,0 @@ - ------ -marketingEvents = new \Doctrine\Common\Collections\ArrayCollection(); - $value = 5; - } -} - -?> diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/fixture.php.inc b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/fixture.php.inc deleted file mode 100644 index 192c52d5..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/fixture.php.inc +++ /dev/null @@ -1,41 +0,0 @@ - ------ -marketingEvents = new \Doctrine\Common\Collections\ArrayCollection(); - } -} - -?> diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added.php.inc b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added.php.inc deleted file mode 100644 index ef7b5ed7..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added.php.inc +++ /dev/null @@ -1,22 +0,0 @@ -marketingEvents = new ArrayCollection(); - $value = 5; - } -} diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added_values.php.inc b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added_values.php.inc deleted file mode 100644 index 4abaeaf3..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/Fixture/skip_added_values.php.inc +++ /dev/null @@ -1,22 +0,0 @@ -marketingEvents = new ArrayCollection([$marketingEvents]); - $value = 5; - } -} diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/FixtureAutoImport/do_not_repetitive_assign.php.inc b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/FixtureAutoImport/do_not_repetitive_assign.php.inc deleted file mode 100644 index e2081e47..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/FixtureAutoImport/do_not_repetitive_assign.php.inc +++ /dev/null @@ -1,90 +0,0 @@ -categories = new ArrayCollection(); - } - -} - -?> ------ -categories = new ArrayCollection(); - } - -} - -?> diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/InitializeDefaultEntityCollectionRectorTest.php b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/InitializeDefaultEntityCollectionRectorTest.php deleted file mode 100644 index ab4501e0..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/InitializeDefaultEntityCollectionRectorTest.php +++ /dev/null @@ -1,28 +0,0 @@ -doTestFile($filePath); - } - - public static function provideData(): Iterator - { - return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); - } - - public function provideConfigFilePath(): string - { - return __DIR__ . '/config/configured_rule.php'; - } -} diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/auto_import.php b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/auto_import.php deleted file mode 100644 index 02153855..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/auto_import.php +++ /dev/null @@ -1,12 +0,0 @@ -importNames(); - - $rectorConfig->rule(InitializeDefaultEntityCollectionRector::class); -}; diff --git a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/configured_rule.php b/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/configured_rule.php deleted file mode 100644 index 92c243af..00000000 --- a/rules-tests/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector/config/configured_rule.php +++ /dev/null @@ -1,10 +0,0 @@ -rule(InitializeDefaultEntityCollectionRector::class); -}; diff --git a/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Fixture/some_class.php.inc b/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Fixture/some_class.php.inc deleted file mode 100644 index aa26a2a1..00000000 --- a/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Fixture/some_class.php.inc +++ /dev/null @@ -1,43 +0,0 @@ - ------ - diff --git a/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Source/Entity/TrainingTerm.php b/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Source/Entity/TrainingTerm.php deleted file mode 100644 index 0fb824c8..00000000 --- a/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/Source/Entity/TrainingTerm.php +++ /dev/null @@ -1,10 +0,0 @@ -doTestFile($filePath); - } - - public static function provideData(): Iterator - { - return self::yieldFilesFromDirectory(__DIR__ . '/Fixture'); - } - - public function provideConfigFilePath(): string - { - return __DIR__ . '/config/configured_rule.php'; - } -} diff --git a/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/config/configured_rule.php b/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/config/configured_rule.php deleted file mode 100644 index 3726e784..00000000 --- a/rules-tests/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector/config/configured_rule.php +++ /dev/null @@ -1,10 +0,0 @@ -rule(TypedPropertyFromDoctrineCollectionRector::class); -}; diff --git a/rules/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector.php b/rules/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector.php index d38eee44..55f228d4 100644 --- a/rules/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector.php +++ b/rules/CodeQuality/Rector/Class_/InitializeDefaultEntityCollectionRector.php @@ -13,8 +13,6 @@ /** * @see https://www.doctrine-project.org/projects/doctrine-orm/en/2.6/reference/best-practices.html#initialize-collections-in-the-constructor * - * @see \Rector\Doctrine\Tests\CodeQuality\Rector\Class_\InitializeDefaultEntityCollectionRector\InitializeDefaultEntityCollectionRectorTest - * * @deprecated This rule can create incomplete assign of object to an array. Use the * @see \Rector\Doctrine\CodeQuality\Rector\Class_\ExplicitRelationCollectionRector instead */ diff --git a/rules/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector.php b/rules/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector.php index 05f8bb5c..be7ee7b3 100644 --- a/rules/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector.php +++ b/rules/CodeQuality/Rector/Property/TypedPropertyFromDoctrineCollectionRector.php @@ -75,7 +75,7 @@ public function getNodeTypes(): array */ public function refactor(Node $node): ?Node { - if ($this->hasWarned === true) { + if ($this->hasWarned) { return null; }