From 54553da9dee4f7f67c82b763a001d7fbfb44c9af Mon Sep 17 00:00:00 2001 From: Jorg Sowa Date: Fri, 20 Dec 2024 00:19:33 +0100 Subject: [PATCH] Return null for no change --- rules/Php84/Rector/FuncCall/RoundingModeEnumRector.php | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/rules/Php84/Rector/FuncCall/RoundingModeEnumRector.php b/rules/Php84/Rector/FuncCall/RoundingModeEnumRector.php index 1ed3e08e5ea..cf36db1c30d 100644 --- a/rules/Php84/Rector/FuncCall/RoundingModeEnumRector.php +++ b/rules/Php84/Rector/FuncCall/RoundingModeEnumRector.php @@ -65,6 +65,7 @@ public function refactor(Node $node): ?Node\Expr\FuncCall $modeArg = $args[2]->value; + $hasChanged = false; if ($modeArg instanceof ConstFetch) { if (isset($modeArg->name->getParts()[0])) { $enumCase = match ($modeArg->name->getParts()[0]) { @@ -80,10 +81,15 @@ public function refactor(Node $node): ?Node\Expr\FuncCall } $args[2]->value = new Node\Expr\ClassConstFetch(new FullyQualified('RoundingMode'), $enumCase); + $hasChanged = true; } } - return $node; + if ($hasChanged) { + return $node; + } + + return null; } public function provideMinPhpVersion(): int