-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyword to find cluster type based on cluster infrastructure #2154
base: master
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
... Returns ${TRUE} if cluster type is Managed | ||
... Returns ${FALSE} if cluster type is Self-Managed | ||
${rc} ${output}= Run And Return Rc And Output | ||
... oc get infrastructure cluster -o jsonpath='{.status.platformStatus.*.resourceTags[?(@.key=="red-hat-managed")].value}' |
Check warning
Code scanning / Robocop
Line is too long ({{ line_length }}/{{ allowed_length }}) Warning test
Robot Results
|
@@ -333,17 +333,15 @@ Wait For Namespace To Be Active | |||
Log ${value} | |||
Should Be Equal As Integers ${rc} 0 | |||
|
|||
Is Cluster Type Self-Managed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you maintain this keyword returning a negation of Is Cluster Type Managed
?
Something like:
${is_managed}= Is Cluster Type Managed
RETURN not ${is_nanaged}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is Cluster Type Managed
keyword covers both the cases for cluster type (managed and self-managed) in one single keyword, which is sufficient in my opinion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can keep it Is Cluster Type Self-Managed
also if you have a strong preference
@jgarciao
This PR
identify the cluster-type