Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Brew tag shouldn't be required to create new release #148

Open
pbabinca opened this issue Feb 21, 2019 · 0 comments
Open

Default Brew tag shouldn't be required to create new release #148

pbabinca opened this issue Feb 21, 2019 · 0 comments

Comments

@pbabinca
Copy link

pbabinca commented Feb 21, 2019 •
edited
Loading

When I try to call errata-tool release create without argument --default_brew_tag I get an error:

errata-tool release create: error: argument --default_brew_tag is required

Web UI doesn't require this - in description for the field I see:

Default brew tag - Overrides default set by the product version.

API apparently doesn't require it either.
pbabinca added a commit to pbabinca/errata-tool that referenced this issue Feb 21, 2019
@pbabinca
release: make --default_brew_tag argument optional
9074d66 
Before this change see --default_brew_tag:

    $ errata-tool release create async --help
    usage: errata-tool release create async [-h] --name NAME --product PRODUCT
                                            --product_version PRODUCT_VERSION
                                            --program_manager PROGRAM_MANAGER
                                            --default_brew_tag DEFAULT_BREW_TAG
                                            [--blocker_flags BLOCKER_FLAGS]

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"

(and respectively for ystream and zstream)

After this change see again --default_brew_tag:

    $ errata-tool release create async --help
    usage: errata-tool release create async [-h] --name NAME --product PRODUCT
                                            --product_version PRODUCT_VERSION
                                            --program_manager PROGRAM_MANAGER
                                            [--default_brew_tag DEFAULT_BREW_TAG]
                                            [--blocker_flags BLOCKER_FLAGS]

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"

(and respectively for ystream and zstream)

Fixes: red-hat-storage#148
pbabinca added a commit to pbabinca/errata-tool that referenced this issue Mar 11, 2019
@pbabinca
release: make --default_brew_tag argument optional
c5d6004 
Before this change see --default_brew_tag:

    $ errata-tool release create async --help
    usage: errata-tool release create async [-h] --name NAME --product PRODUCT
                                            --product_version PRODUCT_VERSION
                                            --program_manager PROGRAM_MANAGER
                                            --default_brew_tag DEFAULT_BREW_TAG
                                            [--blocker_flags BLOCKER_FLAGS]

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"

(and respectively for ystream and zstream)

After this change see again --default_brew_tag:

    $ errata-tool release create async --help
    usage: errata-tool release create async [-h] --name NAME --product PRODUCT
                                            --product_version PRODUCT_VERSION
                                            --program_manager PROGRAM_MANAGER
                                            [--default_brew_tag DEFAULT_BREW_TAG]
                                            [--blocker_flags BLOCKER_FLAGS]

    optional arguments:
      -h, --help            show this help message and exit
      --name NAME           eg. "rhceph-2.4"
      --product PRODUCT     eg. "RHCEPH"
      --product_version PRODUCT_VERSION
                            eg. "RHEL-7-CEPH-3"
      --program_manager PROGRAM_MANAGER
                            eg. "anharris"
      --default_brew_tag DEFAULT_BREW_TAG
                            eg. "ceph-3.0-rhel-7-candidate"
      --blocker_flags BLOCKER_FLAGS
                            eg. "ceph-2.y"

(and respectively for ystream and zstream)

Fixes: red-hat-storage#148
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pbabinca