Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multus: remove csi holder pods key #767

Conversation

Nikhil-Ladha
Copy link
Member

Removed CSI_DISABLE_HOLDER_PODS from the operator deployment files.

Checklist:

  • Commit Message Formatting: Commit titles and messages follow guidelines in the developer guide.
  • Reviewed the developer guide on Submitting a Pull Request
  • Pending release notes updated with breaking and/or notable changes for the next minor release.
  • Documentation has been updated, if necessary.
  • Unit tests have been added, if necessary.
  • Integration tests have been added, if necessary.

removed CSI_DISABLE_HOLDER_PODS from the operator deployment files.

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
add generated csv changes for mutltus key removal

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Copy link

openshift-ci bot commented Oct 29, 2024

@iamniting: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 5, 2024
@BlaineEXE
Copy link

/approve
/lgtm

@agarwal-mudit agarwal-mudit added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2024
Copy link

openshift-ci bot commented Nov 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: BlaineEXE, iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 532e066 into red-hat-storage:master Nov 6, 2024
53 checks passed
@iamniting
Copy link
Member

@Nikhil-Ladha Can you pls provide me a bundle image that includes this commit? I will use that in my PR red-hat-storage/ocs-operator#2609.

@Nikhil-Ladha
Copy link
Member Author

@Nikhil-Ladha Can you pls provide me a bundle image that includes this commit? I will use that in my PR red-hat-storage/ocs-operator#2609.

Here's the bundle image: master-c455c6812 and respective operator image: vmaster-c455c6812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants