From e30e5e881fa19f987bd79bb908fd7ceef7e29a5d Mon Sep 17 00:00:00 2001 From: Praveen M Date: Wed, 31 Jul 2024 19:06:56 +0530 Subject: [PATCH] csi: explicitly set Topology feature-gate issue: external-provisioner (v5) enabled topology feature-gate by default and the current implementation in Rook uses a conditional block to enable the topology feature gate. This approach now does not directly reflect the state of the `CSI_ENABLE_TOPOLOGY`. fix: replacing the conditional block with a direct use of the `CSI_ENABLE_TOPOLOGY` for flag value. Signed-off-by: Praveen M --- .../ceph/csi/template/rbd/csi-rbdplugin-provisioner-dep.yaml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/operator/ceph/csi/template/rbd/csi-rbdplugin-provisioner-dep.yaml b/pkg/operator/ceph/csi/template/rbd/csi-rbdplugin-provisioner-dep.yaml index d8ed72575272..ed25616151ed 100644 --- a/pkg/operator/ceph/csi/template/rbd/csi-rbdplugin-provisioner-dep.yaml +++ b/pkg/operator/ceph/csi/template/rbd/csi-rbdplugin-provisioner-dep.yaml @@ -38,9 +38,7 @@ spec: - "--extra-create-metadata=true" - "--prevent-volume-mode-conversion=true" - "--feature-gates=HonorPVReclaimPolicy=true" - {{ if .EnableCSITopology }} - - "--feature-gates=Topology=true" - {{ end }} + - "--feature-gates=Topology={{ .EnableCSITopology }}" {{ if .KubeApiBurst }} - "--kube-api-burst={{ .KubeApiBurst }}" {{ end }}