Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove anchors inside buttons #18

Open
jaridnft opened this issue Sep 14, 2018 · 2 comments
Open

Remove anchors inside buttons #18

jaridnft opened this issue Sep 14, 2018 · 2 comments

Comments

@jaridnft
Copy link
Collaborator

Currently, the site uses the following structure for buttons:

<button>
    <a href="hyperlink" >text</a>
<button>

This may cause some HTML validation errors, a fix would be:

<a class="button" href="hyperlink>text</a>

Styled with appropriate CSS; be sure to modify @mixin main-cta () inside themes/community-land-trust/src/scc/_mixins.scss to apply styles sitewide.

@vbertoletti
Copy link
Collaborator

Issue has been solved, proper CSS will be added instead to <a>

@jaridnft
Copy link
Collaborator Author

Simply changing the Sass @mixin for buttons will break all buttons site wide.

Going to re-open and deprioritize this for now.

@jaridnft jaridnft reopened this Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants