-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
rules from actions fixed :boar:
- Loading branch information
Showing
2 changed files
with
3 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 comments
on commit 94aba50
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maZahaca for review, redundant _processRule added unnecessary empty scope, it was lead to problems with parsing rows. Selectors was build wrong way, like .row :eq(0)
instead of .row:eq(0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have seen
I don't understand. Why before we parse rule, but now all time we parser actionsResults. What about cases, which don't have actions? or so?
Also it looks strange
(actionsResults, offset, actionsResults)
I believe it fixes something, but I have doubts that it breaks something either.