Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can't override my Chart values #465

Closed
davividal opened this issue Aug 13, 2024 · 5 comments · Fixed by #466
Closed

I can't override my Chart values #465

davividal opened this issue Aug 13, 2024 · 5 comments · Fixed by #466
Assignees

Comments

@davividal
Copy link

I'm trying to verify my chart (https://github.com/SonarSource/helm-chart-sonarqube), but I can't override the default values.

I'm trying to apply this values.yaml:

jwtSecret: "dZ0EB0KxnF++nr5+4vfTCaun/eWbv6gOoXodiAMqcFo="

image:
  image:
  pullSecrets:
    - name: pullsecret
  repository: "sonarsource/sonarqube"
  tag: "10.7.0-community"

I tried both commands without success:

$ docker run --net host -e KUBECONFIG=/.kube/config -v "${HOME}/.kube/":/.kube/ -v "$(pwd)/charts":/charts:z "quay.io/redhat-certification/chart-verifier" -F /charts/sonarqube/ci/openshift-verifier-values.yaml -n sonarqube verify /charts/sonarqube

$ docker run --net host -e KUBECONFIG=/.kube/config -v "${HOME}/.kube/":/.kube/ -v "$(pwd)/charts":/charts:z "quay.io/redhat-certification/chart-verifier" -S image.tag=10.7.0-community (...) -n sonarqube verify /charts/sonarqube

In both cases, it will use the default value for the tag: 10.6.0-community. This also applies to any other value. Adding --debug doesn't show any information.

What am I missing here?

@komish
Copy link
Contributor

komish commented Aug 14, 2024

@davividal I'll take a look. At face value, it would seem like what you're doing should do what you expect here. I'll update here as I have more information.

@komish komish self-assigned this Aug 14, 2024
@komish
Copy link
Contributor

komish commented Aug 14, 2024

@davividal seems to be working here using 1.13.6 of the binary and container image with the -F flag. I'll take a closer look at your chart.

@komish
Copy link
Contributor

komish commented Aug 14, 2024

I can replicate what you're seeing with your chart, but not mine. Still investigating. More to come as I have it.

@komish
Copy link
Contributor

komish commented Aug 14, 2024

^ This PR should resolve it. The core of the issue is that you have a ci/ directory that's factored in incorrectly in chart-verifier. Until we get a release out containing this fix, you can work around this by moving the ci directory in your workflow, and specifying it as extra values (e.g. with -F when calling chart-verifier) manually if you need its content.

@komish
Copy link
Contributor

komish commented Aug 14, 2024

This has merged, and a new release is being cut for it. #467. When this is merged, you should be able to try again with the latest image. In the meantime, you can try with the 0.1.0 tag which should contain the fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants