Skip to content
Permalink

Comparing changes

This is a direct comparison between two commits made in this repository or its related repositories. View the default comparison for this range or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: redhat-developer/app-services-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2f527353f8d50945c3b2e829d62a3725334b0b01
Choose a base ref
..
head repository: redhat-developer/app-services-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 67af9c1a22ce2ad2eec2cd39dd2515087c08c739
Choose a head ref
2 changes: 1 addition & 1 deletion docs/commands/rhoas_connector_namespace.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions docs/commands/rhoas_connector_namespace_create.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions internal/build/build.go
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ import (
type buildSource string

const (
githubBuildSource buildSource = "github"
GithubBuildSource buildSource = "github"
)

// Define public variables here which you wish to be configurable at build time
@@ -75,7 +75,7 @@ func init() {
// the version currently being used. If so, it logs this information
// to the console.
func CheckForUpdate(ctx context.Context, version string, logger logging.Logger, localizer localize.Localizer) {
if BuildSource != string(githubBuildSource) {
if BuildSource != string(GithubBuildSource) {
return
}
// prefix version with a v to correspond with Git tag
5 changes: 5 additions & 0 deletions pkg/core/cmdutil/selfupdate.go
Original file line number Diff line number Diff line change
@@ -53,6 +53,11 @@ func DoSelfUpdate(f *factory.Factory) (bool, error) {

// DoSelfUpdate checks for updates once per day and prompts the user to update if there is a newer version available
func DoSelfUpdateOnceADay(f *factory.Factory) (bool, error) {

if build.BuildSource != string(build.GithubBuildSource) {
return false, nil
}

if !f.IOStreams.CanPrompt() {
// Do not prompt if we are not in interactive mode
return false, nil
5 changes: 1 addition & 4 deletions pkg/core/localize/locales/en/cmd/connectors.toml
Original file line number Diff line number Diff line change
@@ -480,7 +480,7 @@ Commands to manage namespaces for Connectors. A Connectors namespace is the logi
For your own OpenShift Dedicated environment, a Connectors namespace does not automatically expire. You use the information about your Connectors namespace to configure the OpenShift Connectors add-on so that you can use Connectors.
For the Service Preview evaluation site, a Connectors namespace expires 48 hours after you create it. To create an evaluation Connectors namespace include the --eval option with the "connector namespace create" command.
For the Service Preview evaluation site, a Connectors namespace expires 48 hours after you create it.
'''

[connector.namespace.cmd.example]
@@ -522,9 +522,6 @@ one = 'Create a Connectors namespace'
one = '''
# Create a Connectors namespace and name it "my-namespace"
rhoas connector namespace create --name my-namespace
# Create an evaluation Connectors namespace and name it "my-namespace"
rhoas connector namespace create --name my-namespace --eval
'''

[connector.namespace.create.info.success]