Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --certification-component-id as synonym to --certification-project-id #1185

Open
jfrancin opened this issue Jul 19, 2024 · 3 comments · May be fixed by #1222
Open

Add --certification-component-id as synonym to --certification-project-id #1185

jfrancin opened this issue Jul 19, 2024 · 3 comments · May be fixed by #1222
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jfrancin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

As related in Jira PEC-648, the overall Partner Connect certification process and documentation now calls projects by the new term components.

Preflight still refers to these entities as projects rather than components.

Describe the solution you'd like.

Preflight should add a command-line option --certification-component-id in addition to the existing --certification-project-id.
In addition, Preflight should add an environment variable, PFLT_CERTIFICATION_COMPONENT_ID for the same purpose.

To keep existing automation working properly, the existing --certification-project-id option and PFLT_CERTIFICATION_PROJECT_ID environment variable should continue to be accepted if specified. However, only --certification-component-id should be shown in the help flags list. If that is not possible, then change the description to indicate that --certification-project-id is also accepted.

@jfrancin jfrancin added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 19, 2024
@bcrochet bcrochet self-assigned this Nov 22, 2024
bcrochet added a commit to bcrochet/openshift-preflight that referenced this issue Dec 9, 2024
This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@bcrochet bcrochet linked a pull request Dec 9, 2024 that will close this issue
bcrochet added a commit to bcrochet/openshift-preflight that referenced this issue Dec 9, 2024
This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet added a commit to bcrochet/openshift-preflight that referenced this issue Dec 10, 2024
This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet added a commit to bcrochet/openshift-preflight that referenced this issue Dec 10, 2024
This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet added a commit to bcrochet/openshift-preflight that referenced this issue Dec 10, 2024
This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet added a commit to bcrochet/openshift-preflight that referenced this issue Dec 10, 2024
This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@EhsanMo
Copy link

EhsanMo commented Dec 17, 2024

Hi, I faced this same issue while retrieving the certification-project-id. The ID can now be found as the last part of the URL in the component page: https://connect.redhat.com/component/{pid}/{certification-project-id}. Updating the flag to --certification-component-id would align better with the new terminology and avoid confusion

@jfrancin
Copy link
Contributor Author

Just had another partner (Riverbed LLC, case 04015903) who got confused by the fact that we still call it --certification-project-id in Preflight. Any idea when this will be merged and released?

@EhsanMo
Copy link

EhsanMo commented Dec 18, 2024

Screenshot 2024-12-18 at 10 45 49 PM Also, the flag description in the manual should be corrected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants