Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certification-component-id flag #1222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bcrochet
Copy link
Contributor

@bcrochet bcrochet commented Dec 9, 2024

This flag deprecates the certification-project-id flag. The field has been changed on the server side, and in certification documentation.

Fixes #1185

@openshift-ci openshift-ci bot requested review from acornett21 and jomkz December 9, 2024 16:54
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2024
@dcibot
Copy link

dcibot commented Dec 9, 2024

@bcrochet bcrochet force-pushed the fixes/1185 branch 2 times, most recently from 36ccf2f to 8de58b7 Compare December 10, 2024 14:53
@coveralls
Copy link

coveralls commented Dec 10, 2024

Coverage Status

coverage: 84.661% (+0.04%) from 84.619%
when pulling 77ac701 on bcrochet:fixes/1185
into fd13126 on redhat-openshift-ecosystem:main.

@dcibot
Copy link

dcibot commented Dec 10, 2024

@acornett21
Copy link
Contributor

/test 4.17-e2e

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acornett21, bcrochet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [acornett21,bcrochet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dcibot
Copy link

dcibot commented Dec 10, 2024

This flag deprecates the certification-project-id flag. The field has
been changed on the server side, and in certification documentation.

Fixes redhat-openshift-ecosystem#1185

Signed-off-by: Brad P. Crochet <brad@redhat.com>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2024
Copy link

openshift-ci bot commented Dec 10, 2024

New changes are detected. LGTM label has been removed.

@dcibot
Copy link

dcibot commented Dec 11, 2024

@bcrochet
Copy link
Contributor Author

/test 4.17-e2e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add --certification-component-id as synonym to --certification-project-id
4 participants