RingRadius only works with progress parameter

[acaliaro]

🐛 Bug Report

ProgressHUDAppearance.RingRadius allows you to change the size of the spinner. This dimension is applied only if the "progress" parameter is used in the "Show" method. It would be useful to have this scaling even when calling "Show" without the progress

❓ Expected behavior

Changing the RingRadiu changes the size of the spinner independently of other parameters

🪜 Reproduction steps

    public async partial Task ShowAsync()
    {
        await Task.Delay(100);

        ProgressHUDAppearance.HudBackgroundColor = UIColor.Clear;
        ProgressHUDAppearance.RingRadius = 30f;

        BTProgressHUD.Show("", maskType: MaskType.Gradient);

        await Task.Delay(100);
    }

This code does not change the spinner size

🛠 Configuration

Is BTProgressHUD used directy in a MAUI app

📦 Package Version: 2.1.1

📱 iOS Version: 17.3 iphone 12

[acaliaro]

@Cheesebaron @Redth do you have some news for this request? let me know, thanks!!!

[acaliaro]

It seems that the activity indicator is handled differently by the loader. Changing the scale changes the size. What is the best way to implement this feature? Add a parameter to ProgressHUDAppearance specifically for the scale? I notice that by setting a scale > 3, the activity indicator is not completely visible. What could this depend on?

  UIActivityIndicatorView SpinnerView
        {
            get
            {
                _spinnerView ??= new UIActivityIndicatorView(
                    OperatingSystem.IsMacCatalystVersionAtLeast(13, 1) || OperatingSystem.IsIOSVersionAtLeast(13) ?
                        UIActivityIndicatorViewStyle.Large :
                        UIActivityIndicatorViewStyle.WhiteLarge)
                {
                    HidesWhenStopped = true,
                    Bounds = new CGRect(0, 0, 37, 37),
                    Color = ProgressHUDAppearance.RingColor
                };

               **__spinnerView.Transform = CGAffineTransform.MakeScale(ProgressHUDAppearance.ActivityIndicatorScale, ProgressHUDAppearance.ActivityIndicatorScale);_**

                // ReSharper disable once ConditionIsAlwaysTrueOrFalse
                if (_spinnerView.Superview == null)
                    HudView.AddSubview(_spinnerView);

                return _spinnerView;
            }
        }

[Cheesebaron]

I think when you are using transform it doesn't change the bounds of the view itself, just scaling the contents.

I guess if you want ultimate customization, we should make a custom view drawing the spinner instead.

[acaliaro]

Something like https://medium.com/@pankajbawane/create-your-own-uiactivityindicatorview-in-ios-using-swift-d06c5c52cc01

[acaliaro]

@Cheesebaron hi. You say it could be useful to have a property ProgressHUDAppearance.ActivityIndicatorScale that allows to change the scale of the activityindicator? For some it could be enough to change the size of the loader.. let me know I could make a PR

[Cheesebaron]

Sure, you can go ahead and add it