Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom teasers are not supported #149

Open
gwagener opened this issue May 9, 2014 · 3 comments
Open

Custom teasers are not supported #149

gwagener opened this issue May 9, 2014 · 3 comments

Comments

@gwagener
Copy link
Contributor

gwagener commented May 9, 2014

The news items helper news_item_teaser will use the custom teaser if it is present. https://github.com/refinery/refinerycms-news/blob/master/app/helpers/refinery/news/items_helper.rb#L21-L23 However, the news extension doesn't support customer teasers. I think this is a copy paste error as the blog extension does support custom teasers. https://github.com/refinery/refinerycms-blog/blob/master/app/helpers/refinery/blog/posts_helper.rb#L13-L15

The easiest fix would be to remove the incorrect lines from the helper. However, a better solution could be to add support for custom teasers. This should be fairly easy because the rest of what's needed for them could just be copied from the blog extension as well.

@parndt
Copy link
Member

parndt commented May 9, 2014

@gwagener if you wanna support the feature and write tests, sure.

Honestly, sometimes it seems like this extension should just be retired in favour of the blog one ;)

@ugisozols
Copy link
Member

Honestly, sometimes it seems like this extension should just be retired in favour of the blog one ;)

Must resist the community pressure of wanting same features as in refinerycms-blog! :D

@ml242
Copy link

ml242 commented Jul 23, 2014

Is the feature set very different in this engine than in the blog? I was just coming over to see if custom page parts were more supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants