Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In line 30 of the wavelet.py, should "so" be "s0"? #63

Open
DingziHyh opened this issue Feb 15, 2025 · 1 comment
Open

In line 30 of the wavelet.py, should "so" be "s0"? #63

DingziHyh opened this issue Feb 15, 2025 · 1 comment

Comments

@DingziHyh
Copy link

Line 30 in the wavele.py file contains the following text: Default is J = (log2(N * dt / so)) / dj.

25 s0 : float, optional
26 Smallest scale of the wavelet. Default value is 2*dt.
27 J : float, optional
28 Number of scales less one. Scales range from s0 up to
29 s0 * 2**(J * dj), which gives a total of (J + 1) scales.
30 Default is J = (log2(N * dt / so)) / dj.
31 wavelet : instance of Wavelet class, or string
32 Mother wavelet class. Default is Morlet wavelet.
33 freqs : numpy.ndarray, optional
34 Custom frequencies to use instead of the ones corresponding

Should "so" be the same as "s0" in line 25?

@regeirk
Copy link
Owner

regeirk commented Feb 22, 2025

You're right. Thank you for pointing this out. It is minor typo in the docstring. As per https://github.com/regeirk/pycwt/blob/main/pycwt/wavelet.py#L81, it should be s0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants