New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Review #1

Open

griffinh1 opened this issue Dec 5, 2019 · 0 comments

griffinh1 commented Dec 5, 2019 •

edited

Loading

Code author: Jonathan Reibel

Code reviewer: Haeley Griffin

Date of review: 11/21/19

Issues

Formatting/legibility/style

The formatting and legibility on this project is good. I think more comments could be added in order to fully understand what is happening for an outside user. I think the formatting of the files is good and the code seems clean and readable.

Best practices

The best practice of this program is the formatting of the program itself. I believe the setup of the files and the formatting of the code is very readable and makes sense. Although the program is not currently working it is easy to still read the code and understand what is happening.

Reliability

The code currently is not running so I am unsure how reliable this code is. I believe though that the code will be reliable once complete because the code is being tested.

Testability

The code seems to be testable. The author has begun to test the code but the tests do not seem to be complete so that maybe a point to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment