From 67e477c610887282444a92ed9efe2c3348953f6c Mon Sep 17 00:00:00 2001 From: Andrew Schlaikjer Date: Thu, 8 Aug 2024 16:50:40 -0700 Subject: [PATCH 1/2] Updates babel preset-react runtime to "automatic" and cleans up React import lines --- newsfeed/babel.config.json | 14 ++++++++++++-- newsfeed/src/components/App.tsx | 11 ++++++----- newsfeed/src/components/Card.tsx | 6 +++--- newsfeed/src/components/CategorySelector.tsx | 3 +-- newsfeed/src/components/Comment.tsx | 8 +++----- newsfeed/src/components/Heading.tsx | 6 +++--- newsfeed/src/components/Hovercard.tsx | 11 +++++------ newsfeed/src/components/Image.tsx | 4 +--- newsfeed/src/components/LoadMoreCommentsButton.tsx | 4 +--- newsfeed/src/components/LoadingSpinner.tsx | 4 +--- newsfeed/src/components/Newsfeed.tsx | 1 - newsfeed/src/components/OrganizationKind.tsx | 7 +------ newsfeed/src/components/PosterByline.tsx | 3 +-- newsfeed/src/components/PosterBylineLocation.tsx | 8 +++----- newsfeed/src/components/SearchInput.tsx | 2 -- newsfeed/src/components/SmallSpinner.tsx | 4 +--- newsfeed/src/components/Story.tsx | 5 ++--- newsfeed/src/components/StoryCommentsComposer.tsx | 6 ++---- newsfeed/src/components/StoryCommentsSection.tsx | 6 ++---- newsfeed/src/components/StoryLikeButton.tsx | 5 ++--- newsfeed/src/components/playground/GraphiQL.tsx | 4 ++-- newsfeed/src/index.tsx | 7 +++---- newsfeed/src/relay/RelayEnvironment.tsx | 8 ++++---- newsfeed/src/relay/environment.ts | 6 +++--- 24 files changed, 62 insertions(+), 81 deletions(-) diff --git a/newsfeed/babel.config.json b/newsfeed/babel.config.json index 4f014be9..5ff8aebc 100644 --- a/newsfeed/babel.config.json +++ b/newsfeed/babel.config.json @@ -1,4 +1,14 @@ { - "presets": ["@babel/preset-react", "@babel/preset-typescript"], - "plugins": ["relay"] + "presets": [ + [ + "@babel/preset-react", + { + "runtime": "automatic" + } + ], + "@babel/preset-typescript" + ], + "plugins": [ + "relay" + ] } diff --git a/newsfeed/src/components/App.tsx b/newsfeed/src/components/App.tsx index 4d04c1a3..77e07420 100644 --- a/newsfeed/src/components/App.tsx +++ b/newsfeed/src/components/App.tsx @@ -1,16 +1,17 @@ -import * as React from "react"; +import { Suspense } from "react"; + import RelayEnvironment from "../relay/RelayEnvironment"; -import Newsfeed from "./Newsfeed"; import LoadingSpinner from "./LoadingSpinner"; +import Newsfeed from "./Newsfeed"; -export default function App(): React.ReactElement { +export default function App() { return ( - }> + }>
-
+
); } diff --git a/newsfeed/src/components/Card.tsx b/newsfeed/src/components/Card.tsx index 58668d98..a2e29107 100644 --- a/newsfeed/src/components/Card.tsx +++ b/newsfeed/src/components/Card.tsx @@ -1,11 +1,11 @@ -import * as React from "react"; +import { ReactNode } from "react"; export default function Card({ children, dim, }: { - children: React.ReactNode; + children: ReactNode; dim?: boolean; -}): React.ReactElement { +}) { return
{children}
; } diff --git a/newsfeed/src/components/CategorySelector.tsx b/newsfeed/src/components/CategorySelector.tsx index e56feede..49093021 100644 --- a/newsfeed/src/components/CategorySelector.tsx +++ b/newsfeed/src/components/CategorySelector.tsx @@ -1,4 +1,3 @@ -import * as React from "react"; import SmallSpinner from "./SmallSpinner"; // In a real app this would be imported from NewsfeedQuery.graphql; it is only defined @@ -18,7 +17,7 @@ export default function CategorySelector({ value: Category; onChange: (newValue: Category) => void; isPending?: boolean; -}): React.ReactElement { +}) { return (