Email settings user widget - can't subscribe user to list

[ricco24]

EmailSettingsFormFactory in formSucceeded loads only user preferences. So user can't be subscribed to new created mailing list because user doesn't have record in user_subscriptions table for this list.

[rootpd]

Hm, that's weird. Creating mailing list should trigger creation of mail_user_subscription record in Mailer. Looking at the handler, I see the issue: https://github.com/remp2020/remp/blob/master/Mailer/app/hermes/ListCreatedHandler.php#L41

We'll remove this line so the record is always created correctly.

Until then, please run php bin/command.php mail:sync-user-subscriptions in Mailer to add missing mail subscription records.

[ricco24]

As i see this is not problem with mailer but with mailer module. In EmailSettingsFormFactory is iteration only over userPreferences.

crm-remp-mailer-module/src/Forms/EmailSettingsFormFactory.php

Line 155 in a3db2bf

$userPreferences = $this->mailUserSubscriptionsRepository->userPreferences($values['user_id']);

So if user has no record for list in mail_user_subscriptions then it is impossible to subscribe user via this widet to this list.

[ricco24]

After your fix in mailer i think this problem persists only on not auto subscribe lists.

[rootpd]

@ricco24 Reading userPreferences is intentional, as there's an expectation that Mailer keeps track of all newsletter-user subscription combinations. That means that each user should have record (userPreference) for each newsletter whether she is subscribed to it or not. That's why reading userPreferences` should be sufficient.

When the new user is registered, CRM calls Register API to create these records (see highlighted lines):
https://github.com/remp2020/remp/blob/master/Mailer/app/api/v1/Handlers/Users/UserRegisteredHandler.php#L65

And when new newsletter is created in Mailer, it's handled by the handler I referenced before:
https://github.com/remp2020/remp/blob/master/Mailer/app/hermes/ListCreatedHandler.php#L47

It looks to me that there are only these two scenarios that can affect mail_user_subscriptions and both are covered by CRM's Mailer module and by REMP Mailer.

Are you still seeing the issue, after running the mail:sync-user-subscriptions command and trying the fixed version from July 13+? If so, is there a way how to identify the users with missing newsletter subscription info? (whether they're new registrations?)