Implement new models

[renecotyfanboy]

We are willing to implement many xspec models that could be relevant to use

Additive components

• agauss
• zagauss
• agnsed
• qsosed
• agnslim
• apec
• vapec
• vvapec
• atable
• bapec
• bvapec
• bvvapec
• bbody
• zbbody
• bbodyrad
• bexrav
• bexriv
• bkn2pow
• bknpower
• zbknpower
• bmc
• bremss
• vbremss
• zbremss
• brnei
• bvrnei
• bvvrnei
• btapec
• bvtapec
• bvvtapec
• bwcycl
• c6mekl
• c6vmekl
• c6pmekl
• c6pvmkl
• carbatm
• cemekl
• cevmkl
• cflow
• compbb
• compLS
• compmag
• compPS
• compST
• comptb
• compTT
• cph
• vcph
• cplinear
• cutoffpl
• zcutoffpl
• disk
• diskbb
• diskir
• diskline
• diskm
• disko
• diskpbb
• diskpn
• eplogpar
• eqpair
• eqtherm
• compth
• equil
• vequil
• expdec
• ezdiskbb
• gadem
• vgadem
• gauss
• zgauss
• gnei
• vgnei
• vvgnei
• grad
• grbcomp
• grbjet
• grbm
• hatm
• jet
• kerrbb
• zkerrbb
• kerrd
• kerrdisk
• kyrline
• laor
• laor2
• logpar
• zlogpar
• lorentz
• meka
• vmeka
• mekal
• vmekal
• mkcflow
• vmcflow
• nei
• vnei
• vvnei
• nlapec
• npshock
• vnpshock
• vvnpshock
• nsa
• nsagrav
• nsatmos
• nsmax
• nsmaxg
• nsx
• nteea
• nthcomp
• optxagnf
• optxagn
• pegpwrlw
• pexmon
• pexrav
• pexriv
• plcabs
• polconst
• pollin
• polpow
• posm
• powerlaw
• zpowerlw
• pshock
• vpshock
• vvpshock
• raymond
• vraymond
• redge
• refsch
• relline
• relline_lp
• relline_lp_ext
• rnei
• vrnei
• vvrnei
• sedov
• vsedov
• vvsedov
• sirf
• slimbh
• smaug
• snapec
• srcut
• sresc
• ssa
• step
• tapec
• vtapec
• vvtapec
• wdem
• vwdem
• vvwdem
• voigt

Multiplicative components

• absori
• acisabs
• cabs
• constant
• cyclabs
• dust
• edge
• zedge
• etable
• expabs
• expfac
• gabs
• heilin
• highecut
• zhighect
• hrefl
• ismabs
• ismdust
• logconst
• log10con
• lyman
• mtable
• notch
• olivineabs
• pcfabs
• zpcfabs
• phabs
• vphabs
• zphabs
• zvphabs
• plabs
• pwab
• redden
• smedge
• spexpcut
• spline
• SSSice
• swind1
• tbabs
• ztbabs
• tbfeo
• tbgas
• tbgrain
• tbpcf
• tbvarabs
• tbrel
• uvred
• varabs
• zvarabs
• wabs
• zwabs
• wndabs
• zwndabs
• xion
• xscat
• zbabs
• zdust
• zigm
• zredden
• zsmdust
• zvfeabs
• zxipab
• zxipcf

Convolution components

• cflux
• cglumin
• clumin
• cpflux
• gsmooth
• ireflect
• kdblur
• kdblur2
• kerrconv
• kyconv
• lsmooth
• partcov
• rdblur
• reflect
• relconv
• relconv_lp
• relconv_lp_ext
• rfxconv
• rgsxsrc
• simpl
• ThComp
• vashift
• vmshift
• xilconv
• zashift

Pile-up and mixing models to come ?

[renecotyfanboy]

#48 add cutoffpl

[renecotyfanboy]

#108 Added diskpbb & diskbb

[renecotyfanboy]

#122 Added agauss, zagauss & zgauss

[JohannesBuchner]

You can probably recycle a lot of code (with the right units) from astromodels:

• spectral functions: https://astromodels.readthedocs.io/en/latest/notebooks/function_list.html
• https://github.com/threeML/astromodels/tree/master/astromodels/functions/functions_1D
• table models (atable/mtable/etable): https://github.com/threeML/astromodels/blob/master/astromodels/functions/template_model.py#L851

I wonder if for simple apec (only as a function of temperature within some range, fixed chosen abundances), the logarithm of the model spectrum may not be approximated with a quadratic function of temperature for each spectral energy bin. Even better would be an emulator, but that's way more involved.

For pexmon (superseding pexrav), an alternative is the disk table model available at https://github.com/JohannesBuchner/xars/blob/master/doc/README.rst#disk from https://ui.adsabs.harvard.edu/abs/2019A%26A...629A..16B/abstract

[renecotyfanboy]

Thank you very much for your insights ! I've already stolen code and tables from astromodels (in particular the absorption tables), but wasn't here they had a wrapper for xspec tabulated models, good thing to know

For you to know, we are dealing with APEC internally right now, it might be released in a week or two (vvapec at least), more details in #111, we finally chose to use directly the continuum, pseudo continuum and emission lines tables as provided by AtomDB, and it seems to work pretty well (on my computer at least). This should be equivalent to the implementation in xspec, I am starting the tests anytime soon

[renecotyfanboy]

@alessandropeca I am moving this here

This would be extremely helpful! Models like MYTORUS or UXCLUMPY are built on XSPEC tables, and it would be extremely helpful to be able to import them.