Buildkite: Support multiple plugins per pipeline section

[rarkins]

This is a:

• Bug report (non-security related)
• Feature request
• I'm not sure which of those it is

Please describe the issue:

Currently Renovate only looks for the first line of a plugins: section in the pipeline yml. Instead, we should support multiple nested plugins if found.

[rarkins]

• Define a valid example buildkite definition to use which has multiple plugins in one pipeline
• Enhance the buildkite/extract function to extract multiple dependencies per file
• Enhance the buildkite/update function (if necessary) to support patching a multi-dependency file. It's possible it already works
• Test it against a real repo. Run multiple times to make sure it doesn't unnecessarily keep editing each time.
• Add unit tests

[rarkins]

@toolmantim @ticky do you have a valid example of a buildkite file with multiple plugins per pipeline?

[toolmantim]

I've been meaning to reach out to fix Renovate's handling of our plugin syntax, because we've changed it from being a map/hash to being an array. And since we have, Renovate has stop parsing them it seems.

This is the old syntax, which is still valid, but not recommended because older Buildkite agents won't guarantee the order in which they're run:

steps:
  - plugins:
      docker-login#v2.0.1:
        username: xyz
      docker-compose#v2.5.1:
        build: app
        image-repository: index.docker.io/myorg/myrepo
  - wait
  - command: test.sh
    plugins:
      docker-login#v2.0.1:
        username: xyz
      docker-compose#v2.5.1:
        run: app

The new syntax is:

steps:
  - plugins:
      - docker-login#v2.0.1:
          username: xyz
      - docker-compose#v2.5.1:
          build: app
          image-repository: index.docker.io/myorg/myrepo
  - wait
  - command: test.sh
    plugins:
      - docker-login#v2.0.1:
          username: xyz
      - docker-compose#v2.5.1:
          run: app

I think

renovate/lib/manager/buildkite/extract.js

Line 20 in 44d1198

const depLineMatch = depLine.match(/^\s+([^#]+)#([^:]+):/);

is the part that needs updating, perhaps to ^\s+(?:-\s+)?([^#]+)#([^:]+):

[rarkins]

@toolmantim thanks for the examples. I have used that regex successfully to fix it partially. It now will parse the first element of an array, but not subsequent ones. i.e. this issue's main topic still remains - support multiple dependencies per plugins array.

Can you also clarify how image-repository is meant to work - does Renovate need to care about that or still just go to github all the same?

[toolmantim]

Oh, I see! No worries, thanks for the other fix tho ❤️

All the subkeys (e.g. image-repository, username, build and run) are configuration options of each plugin, and you should ignore them.