Support for upgrading Maven Wrapper beyond version 3.3.0 #28648
Replies: 6 comments 4 replies
-
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. To get started, please read our guide on creating a minimal reproduction. Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
Thanks for all the prior work! Would you be able to create the 3 use cases?
I don't think necessary to duplicate with Windows too unless you want. Then we can implement your suggested logic and make sure they all work in repos as intended |
Beta Was this translation helpful? Give feedback.
-
I've created a little script to generate examples for Maven Wrapper 3.2.0, 3.3.0 and 3.3.1: create-examples.sh.zip Here is an archive of the generated examples: examples.zip Note that
That leaves projects that use Maven Wrapper 3.3.0 with the default |
Beta Was this translation helpful? Give feedback.
-
I started on a Pull Request to fix these scenario's:
is the following something we want to do? If neither of the above yield a result, check for the string Apache Maven Wrapper startup batch script, version 3.3.0 in mvnw, or if absent in mvnw.cmd. This should cover projects that use Maven Wrapper 3.3.0. is that going to effect a lot people? |
Beta Was this translation helpful? Give feedback.
-
Related discussion - #31696 (I didn't find this when I originally searched, apologies) |
Beta Was this translation helpful? Give feedback.
-
I think that now the remaining unsupported scenario is when the current version is exactly 3.3.0? |
Beta Was this translation helpful? Give feedback.
-
What would you like help with?
I think I found a bug
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
GitLab, Renovate 37.323.0
Please tell us more about your question or problem
Maven Wrapper 3.3.0 removed the
wrapperUrl
property from the.mvn/wrapper/maven-wrapper.properties
file in projects that use Maven Wrapper.I believe Renovate uses the
wrapperUrl
to determine the Maven Wrapper version, so after the upgrade to Maven Wrapper 3.3.0 Renovate will not be able to determine the Maven Wrapper version.I requested a reliable way to determine the Maven Wrapper version (MWRAPPER-134) and this has been delivered in Maven Wrapper 3.3.1 in the form of a new
wrapperVersion
property in.mvn/wrapper/maven-wrapper.properties
.I believe the logic to determine the Maven Wrapper will need to be extended to the following to make sure that Renovate will continue to be able to keep Maven Wrapper up-to-date:
wrapperVersion
property in.mvn/wrapper/maven-wrapper.properties
. Use its value when present. This should cover projects that use Maven Wrapper 3.3.1 and later.wrapperUrl
property, check for thewrapperUrl
property in.mvn/wrapper/maven-wrapper.properties
and parse the version from that when present. This should cover projects that use Maven Wrapper before version 3.3.0.Apache Maven Wrapper startup batch script, version 3.3.0
inmvnw
, or if absent inmvnw.cmd
. This should cover projects that use Maven Wrapper 3.3.0.Logs (if relevant)
No response
Beta Was this translation helpful? Give feedback.
All reactions