How can I update the lock file in the same PR as the dependency update?

[Otiel]

What would you like help with?

I would like help with my configuration

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab - Renovate 38.77.3

Please tell us more about your question or problem

Is it possible to update the lock files (specifically NuGet lock files: packages.lock.json) in the same PR where the dependency is updated?

We guarantee with our CI that the lock file is always up-to-date, else the PR cannot be merged.

I've tried the following configuration, advised in this comment, but the lock file isn't updated in the PR:

  "packageRules": [
    {
      "matchUpdateTypes": ["minor", "patch", "lockFileMaintenance"],
      "groupName": "dependencies (minor and patch upgrades)",
    }
  ],

Logs (if relevant)

No log relevant to the lock file, except listing the lock files existing for each of our csproj.

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide.
Good luck,

The Renovate team

[rarkins]

That should be the default behavior. Please create a reproduction repo to demonstrate if you're seeing otherwise

[Otiel]

Thanks for the reply. I've finally found the time to test on GitHub using the Mend Renovate App, but I could not reproduce the issue I'm getting with a self-hosted Renovate. Everything works fine on GitHub.

But doing more tests, I've found out where the issue comes from: as I am in an air-gapped environment, Renovate does not have access to nuget.org. When running the dotnet restore command, it tries to access nuget.org and fails with the following log:

DEBUG: rawExec err (repository=group/repo, branch=renovate/upgrade-dependencies)
       "err": {
         "cmd": "/bin/sh -c dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config",
         "stderr": "",
         "stdout": "  Determining projects to restore...\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1900: Warning As Error: Error occurred while getting package vulnerability data: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n  Failed to restore /tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj (in 13.45 min).\n",
         "options": {
           "cwd": "/tmp/renovate/repos/gitlab/group/repo",
           "encoding": "utf-8",
           "env": {
             "NUGET_PACKAGES": "/tmp/renovate/cache/__renovate-private-cache/nuget/packages",
             "MSBUILDDISABLENODEREUSE": "1",
             "HOME": "/home/ubuntu",
             "PATH": "/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin",
             "LC_ALL": "C.UTF-8",
             "LANG": "C.UTF-8",
             "NODE_EXTRA_CA_CERTS": "/usr/local/share/ca-certificates/ca.crt"
           },
           "maxBuffer": 10485760,
           "timeout": 900000
         },
         "exitCode": 1,
         "name": "ExecError",
         "message": "Command failed: dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config\n",
         "stack": "ExecError: Command failed: dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config\n\n    at ChildProcess.<anonymous> (/usr/local/renovate/lib/util/exec/common.ts:101:11)\n    at ChildProcess.emit (node:events:531:35)\n    at ChildProcess.emit (node:domain:488:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:294:12)"
       },
       "durationMs": 807763
DEBUG: Failed to generate lock file (repository=group/repo, branch=renovate/upgrade-dependencies)
       "err": {
         "cmd": "/bin/sh -c dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config",
         "stderr": "",
         "stdout": "  Determining projects to restore...\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1301: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n/tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj : error NU1900: Warning As Error: Error occurred while getting package vulnerability data: Unable to load the service index for source https://api.nuget.org/v3/index.json.\n  Failed to restore /tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj (in 13.45 min).\n",
         "options": {
           "cwd": "/tmp/renovate/repos/gitlab/group/repo",
           "encoding": "utf-8",
           "env": {
             "NUGET_PACKAGES": "/tmp/renovate/cache/__renovate-private-cache/nuget/packages",
             "MSBUILDDISABLENODEREUSE": "1",
             "HOME": "/home/ubuntu",
             "PATH": "/home/ubuntu/.local/bin:/home/ubuntu/bin:/home/ubuntu/.local/bin:/home/ubuntu/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin",
             "LC_ALL": "C.UTF-8",
             "LANG": "C.UTF-8",
             "NODE_EXTRA_CA_CERTS": "/usr/local/share/ca-certificates/ca.crt"
           },
           "maxBuffer": 10485760,
           "timeout": 900000
         },
         "exitCode": 1,
         "name": "ExecError",
         "message": "Command failed: dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config\n",
         "stack": "ExecError: Command failed: dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config\n\n    at ChildProcess.<anonymous> (/usr/local/renovate/lib/util/exec/common.ts:101:11)\n    at ChildProcess.emit (node:events:531:35)\n    at ChildProcess.emit (node:domain:488:12)\n    at Process.ChildProcess._handle.onexit (node:internal/child_process:294:12)"
       }

Thus the packages.lock.json file is not updated.

Now, I think there's an issue with Renovate. It should not try to access nuget.org because I've disabled the PackageSource in my nuget.config file present in the repository:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <add key="artifactory" value="https://my-private-package-source/artifactory/api/nuget/nuget" />
  </packageSources>
  <disabledPackageSources>
    <add key="nuget.org" value="true" />
  </disabledPackageSources>
</configuration>

But here is the content of the /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config file passed to dotnet restore:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <packageSources>
        <add key="nuget.org" value="https://api.nuget.org/v3/index.json" protocolVersion="3" />
        <add key="artifactory" value="https://my-private-package-source/artifactory/api/nuget/nuget" protocolVersion="2" />
    </packageSources>
</configuration>

If I edit my nuget.config file in my repository to clear PackageSources (and not just disable nuget.org):

<?xml version="1.0" encoding="utf-8"?>
<configuration>
  <packageSources>
    <clear />
    <add key="artifactory" value="https://my-private-package-source/artifactory/api/nuget/nuget" />
  </packageSources>
</configuration>

Then here is the content of the /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config file:

<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <packageSources>
        <add key="artifactory" value="https://my-private-package-source/artifactory/api/nuget/nuget" protocolVersion="2" />
    </packageSources>
</configuration>

Then, the dotnet restore commands runs with success, and the packages.lock.json file is correctly updated:

DEBUG: Executing command (repository=group/repo, branch=renovate/upgrade-dependencies)
       "command": "dotnet restore RenovateTest/RenovateTest/RenovateTest.csproj --force-evaluate --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config"
DEBUG: exec completed (repository=group/repo, branch=renovate/upgrade-dependencies)
       "durationMs": 125743,
       "stdout": "  Determining projects to restore...\n  Restored /tmp/renovate/repos/gitlab/group/repo/RenovateTest/RenovateTest/RenovateTest.csproj (in 2.08 min).\n",
       "stderr": ""
DEBUG: Updated 1 package files (repository=group/repo, branch=renovate/upgrade-dependencies)
DEBUG: Updated 1 lock files (repository=group/repo, branch=renovate/upgrade-dependencies)
       "updatedArtifacts": ["RenovateTest/RenovateTest/packages.lock.json"]

Unfortunately, clearing the PackageSources in the nuget.config of my repository is not an option for me.

Now,

• Why is the --configfile /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config option passed to the dotnet restore command?
• Why is it not the nuget.config file of my repository that is passed?
• If passing this option is required with a nuget.config file built by Renovate, I think the /tmp/renovate/cache/__renovate-private-cache/nuget/nuget.config should be constructed by taking into account the <disabledPackageSources> (and all other possible values) of the nuget.config file of the repository.

And even more confusing :

• Even though the source nuget.org is present, why isn't my source "artifactory" used to perform the dotnet restore?
• When I clear the PackageSources in order to have only my "artifactory" source, the dotnet restore command takes about 2 min to run 🤯, whereas it runs locally in my repository in under 1 sec. Why is it so long?

[rarkins]

It's hard to tell if it's an outright bug or overlooked functionality for cases like yours, but either way we unfortunately don't have time to look into it with the detail necessary when it impacts such a narrow use case (only yourself for now). You are welcome to try to troubleshoot and fix it yourself, and we can provide advice/assistance for you as a contributor to the project. Alternatively you can wait for someone else with the same problem to come along and fix it, but otherwise for enterprise users such as yourself without the time or ability to solve problems themselves, and who need things fixed or added, please see

renovate/docs/usage/about-us.md

Line 54 in 3986459

### Getting more paid help

[Otiel]

I've created a PR to take into account the <disabledPackageSources> element.