config migration loses regexManagers when customManagers are present #32020
Replies: 1 comment
-
Having both old and new options in the same config should be considered a config error and not a valid use case. I've looked at the migration code we have for such cases and don't see any quick way to handle this, and don't think it's worth our time to figure out how to do do. You are welcome to contribute a PR if you can find an elegant way. The starting point would be https://github.com/renovatebot/renovate/blob/main/lib/config/migrations/base/rename-property-migration.ts It's also not blocking for enabling configMigration regardless because users are still expected to review the proposed migrations. We can't have a "it must be perfect otherwise we can never enable it" policy. |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
A Mend.io-hosted app
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
No response
Please tell us more about your question or problem
When the renovate configuration has both
regexManagers
andcustomManagers
set, Renovate should migrate both theregexManagers
andcustomManagers
intocustomManagers
. However, it actually just drops theregexManagers
.Here's a PR created by Renovate demonstrating this issue: candrews/renovate-config-migration#3
I believe this issue should block enabling
configMigration
by default: #16359Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions