Patch update PRs created despite configuration #34474
Replies: 1 comment 6 replies
-
|
Hi there, Please help this Discussion progress by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. Please follow these steps:
If you need help with running renovate on your minimal reproduction repository, please refer to our Running Renovate guide. The Renovate team |
Beta Was this translation helpful? Give feedback.
-
|
We'd need the full debug logs from the real environment to try to double check that the config is what you think it is. |
Beta Was this translation helpful? Give feedback.
-
|
Sure thing. Here is the full DEBUG log that created the unexpected PR. Many other PRs have been created unexpected for |
Beta Was this translation helpful? Give feedback.
-
|
Is the groupName rule above it also not applying? If so then it would seem like something wrong with the matchPackageNames value/matching, but it's hard to see why |
Beta Was this translation helpful? Give feedback.
-
|
Great point. I believe your suspicion is correct because the PR is titled "Update dependency Microsoft.VisualStudio.RpcContracts to v17.13.12" instead of "Visual Studio SDK". |
Beta Was this translation helpful? Give feedback.
-
|
What is the difference between |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
Self-hosted Renovate
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
Azure DevOps
Please tell us more about your question or problem
A PR was created that updated Directory.Packages.props with this:
This is a patch-only update. But my renovate.json file has this at the very bottom:
{ "matchPackageNames": ["Microsoft.VisualStudio.*"], "matchUpdateTypes": ["patch"], "enabled": false }As it is at the very bottom, I expect(?) that it trumps any policy that precedes it. The package name pattern and update type should match. And since
enabledis set tofalse, I thought this would prevent such PRs from being created.What am I doing wrong?
Logs (if relevant)
renovate.json
{ "$schema": "https://docs.renovatebot.com/renovate-schema.json", "extends": ["config:recommended"], "semanticCommits": "disabled", "labels": ["dependencies"], "packageRules": [ { "matchPackageNames": ["nbgv", "nerdbank.gitversioning"], "groupName": "nbgv and nerdbank.gitversioning updates" }, { "matchPackageNames": ["xunit*"], "groupName": "xunit" }, { "matchDatasources": ["dotnet-version", "docker"], "matchDepNames": ["dotnet-sdk", "mcr.microsoft.com/dotnet/sdk"], "groupName": "Dockerfile and global.json updates" }, { "matchPackageNames": ["*"], "allowedVersions": "!/-g[a-f0-9]+$/" }, { "matchPackageNames": [ "System.Collections.Immutable", "System.Composition*", "System.Diagnostics.DiagnosticSource", "System.IO.Pipelines", "System.Reflection.Metadata", "System.Text.Json", "System.Threading.Tasks.Dataflow", "Microsoft.Bcl.AsyncInterfaces" ], "allowedVersions": "<9.0", "groupName": "Included in .NET runtime" }, { "matchPackageNames": ["Microsoft.VisualStudio.Internal.MicroBuild*"], "groupName": "microbuild" }, { "matchPackageNames": ["Microsoft.VisualStudio.*"], "groupName": "Visual Studio SDK" }, { "matchPackageNames": ["Microsoft.VisualStudio.*"], "matchUpdateTypes": ["patch"], "enabled": false } ] }Logs
Beta Was this translation helpful? Give feedback.
All reactions