Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignoreDeps in group presets causes error when combined with matchUpdateTypes #31986

Open
RahulGautamSingh opened this issue Oct 16, 2024 · 5 comments
Open

ignoreDeps in group presets causes error when combined with matchUpdateTypes #31986

RahulGautamSingh opened this issue Oct 16, 2024 · 5 comments
Labels
core:config Related to config capabilities and presets priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:bug Bug fix of existing functionality

Comments

@RahulGautamSingh
Copy link
Collaborator

RahulGautamSingh commented Oct 16, 2024 •
edited
Loading

Describe the proposed change(s).

We added ignoreDeps to the group presets in this PR as a hack to shorten the onboarding PR description.

But, now we cannot combine the group presets with matchUpdateTypes as the preset contains ignoreDeps. So, while the hack fixed one problem it introduced another.

We need to find another way to shorten the onboarding PR description and remove ignoreDeps from the group preset config.

Ref: #31972
@RahulGautamSingh RahulGautamSingh added type:bug Bug fix of existing functionality priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others core:config Related to config capabilities and presets labels Oct 16, 2024
@rarkins
Copy link
Collaborator

rarkins commented Oct 16, 2024

Are you sure you have the link right? I don't see mention of ignoreDeps in https://github.com/renovatebot/renovate/pull/9836/files

@RahulGautamSingh
Copy link
Collaborator Author

My bad, updated the link

@rarkins
Copy link
Collaborator

rarkins commented Oct 16, 2024

Are you sure that PR added ignoreDeps anywhere? Looks like it was already there and was just commented

@RahulGautamSingh
Copy link
Collaborator Author

True. I did some mistake while checking blame and could not find the ignoreDeps before that PR.

It seems the ignoreDeps has always been there, since that file was created. I don't think it is needed though.

@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Oct 17, 2024
@rarkins
Copy link
Collaborator

rarkins commented Oct 17, 2024

I've marked this as low priority - a community member can investigate if it's possible to remove it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core:config Related to config capabilities and presets priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rarkins @RahulGautamSingh