Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
574b4e3
[PRO-1150] first set of asserts on ErrorEvent messages
Domiii Apr 15, 2025
68a1a80
update backend rev
Domiii Apr 15, 2025
d9286c5
DEPS (v8)
Domiii Apr 15, 2025
de40ae5
DEPS (v8)
Andarist Apr 15, 2025
f92606c
DEPS (v8)
Domiii Apr 15, 2025
876571e
DEPS (v8)
Andarist Apr 16, 2025
b7b9912
DEPS (v8)
Andarist Apr 16, 2025
c2702ec
add extra assert
Andarist Apr 16, 2025
3f4cc9c
compile error
Domiii Apr 16, 2025
7b866b0
Merge branch 'andarist/pro-1105-divergences-caused-when-instrumenting…
Domiii Apr 16, 2025
aed5c79
Merge branch 'dominik/pro-1150-analysis-fatal-errors-causing-many-cha…
Domiii Apr 16, 2025
f947023
DEPS (v8)
Domiii Apr 16, 2025
10c6dcd
fix stupid mistake
Domiii Apr 16, 2025
b0c87ca
DEPS (v8)
Domiii Apr 16, 2025
84bab23
add extra asserts
Andarist Apr 16, 2025
2429573
add extra asserts
Andarist Apr 16, 2025
059a43b
add extra asserts
Andarist Apr 16, 2025
dd0e36a
add print
Andarist Apr 16, 2025
7770fc2
fix silly mistake
Andarist Apr 16, 2025
5e7e0e1
DEPS (v8)
Domiii Apr 17, 2025
ac083da
DEPS (v8)
Domiii Apr 17, 2025
ce6b513
DEPS (v8)
Andarist Apr 17, 2025
9db96cd
DEPS (v8)
Andarist Apr 17, 2025
c1252b7
DEPS (v8)
Andarist Apr 17, 2025
b978f9f
DEPS (v8)
Andarist Apr 17, 2025
5bdc214
DEPS (v8)
Andarist Apr 17, 2025
49cdd58
DEPS (v8)
Andarist Apr 17, 2025
3aa73fe
DEPS (v8)
Andarist Apr 17, 2025
6e3c4a8
DEPS (v8)
Domiii Apr 18, 2025
52b42c8
Merge branch 'andarist/pro-1105-divergences-caused-when-instrumenting…
Domiii Apr 18, 2025
4097bcb
DEPS (v8)
Domiii Apr 18, 2025
f0c737b
DEPS (v8)
Domiii Apr 18, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ vars = {
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling V8
# and whatever else without interference from each other.
'v8_revision': '5e69d807b5e54f89546486c81eedc0ae35d6c819',
'v8_revision': 'dd0b5a315bab8e519379998172b7f316d7f5b299',
# Three lines of non-changing comments so that
# the commit queue can handle CLs rolling swarming_client
# and whatever else without interference from each other.
Expand Down
2 changes: 1 addition & 1 deletion REPLAY_BACKEND_REV
Original file line number Diff line number Diff line change
@@ -1 +1 @@
896a776a2587dc1fa8403efbdc424436fb0809bc
9bbe62c72b1608d212f99c9fc8ed0917e455205a
8 changes: 8 additions & 0 deletions fuchsia_web/webengine/browser/frame_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1344,6 +1344,14 @@ bool FrameImpl::DidAddMessageToConsole(

std::string source_id_utf8 = base::UTF16ToUTF8(source_id);
std::string message_utf8 = base::UTF16ToUTF8(message);
recordreplay::Assert(
"[PRO-1150] FrameImpl::DidAddMessageToConsole source_id %s",
source_id_utf8.c_str());
recordreplay::Assert(
"[PRO-1150] FrameImpl::DidAddMessageToConsole message %s",
message_utf8.c_str());
recordreplay::Assert(
"[PRO-1150] FrameImpl::DidAddMessageToConsole line_no %d", line_no);
console_logger_.LogMessage(source_id_utf8, line_no, message_utf8, severity);

return true;
Expand Down
9 changes: 7 additions & 2 deletions third_party/blink/renderer/bindings/core/v8/v8_initializer.cc
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ void V8Initializer::MessageHandlerInMainThread(v8::Local<v8::Message> message,
return;
}

String source = ToCoreStringWithUndefinedOrNullCheck(
message->GetSource(script_state->GetContext()).ToLocalChecked());
recordreplay::Assert("MessageHandlerInMainThread %s", source.Utf8().c_str());

const auto sanitize_script_errors = message->IsSharedCrossOrigin()
? SanitizeScriptErrors::kDoNotSanitize
: SanitizeScriptErrors::kSanitize;
Expand Down Expand Up @@ -481,8 +485,9 @@ CodeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context,
return {true, std::move(stringified_source)};
}

bool V8Initializer::WasmCodeGenerationCheckCallbackInMainThread(v8::Local<v8::Context> context,
v8::Local<v8::String> source) {
bool V8Initializer::WasmCodeGenerationCheckCallbackInMainThread(
v8::Local<v8::Context> context,
v8::Local<v8::String> source) {
if (ExecutionContext* execution_context = ToExecutionContext(context)) {
if (ContentSecurityPolicy* policy =
execution_context->GetContentSecurityPolicy()) {
Expand Down
3 changes: 3 additions & 0 deletions third_party/blink/renderer/core/events/error_event.cc
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ ErrorEvent::ErrorEvent(ScriptState* script_state,
sanitized_message_(),
world_(&script_state->World()) {
sanitized_message_ = initializer->message();
recordreplay::Assert("[PRO-1150] ErrorEvent::ErrorEvent A %s", sanitized_message_.Utf8().c_str());
location_ = std::make_unique<SourceLocation>(initializer->filename(),
String(), initializer->lineno(),
initializer->colno(), nullptr);
Expand All @@ -89,13 +90,15 @@ ErrorEvent::ErrorEvent(const String& message,
sanitized_message_(message),
location_(std::move(location)),
world_(world) {
recordreplay::Assert("[PRO-1150] ErrorEvent::ErrorEvent B %s", sanitized_message_.Utf8().c_str());
if (!error.IsEmpty())
error_.Set(error.GetIsolate(), error.V8Value());
}

void ErrorEvent::SetUnsanitizedMessage(const String& message) {
DCHECK(unsanitized_message_.empty());
unsanitized_message_ = message;
recordreplay::Assert("[PRO-1150] ErrorEvent::SetUnsanitizedMessage %s", message.Utf8().c_str());
}

ErrorEvent::~ErrorEvent() = default;
Expand Down
18 changes: 17 additions & 1 deletion third_party/blink/renderer/core/page/chrome_client_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -409,12 +409,28 @@ void ChromeClientImpl::AddMessageToConsole(LocalFrame* local_frame,
"ChromeClientImpl::AddMessageToConsole source_id", source_id_str);
const String new_source_id =
String::FromUTF8(&stack_trace_str[0], stack_trace_str.length());
recordreplay::Print(
"ChromeClientImpl::AddMessageToConsole (print) source_id %s",
source_id.Utf8().c_str());
recordreplay::Print(
"ChromeClientImpl::AddMessageToConsole (print) new_source_id %s",
new_source_id.Utf8().c_str());

recordreplay::Assert(
"[PRO-1150] ChromeClientImpl::AddMessageToConsole source_id %s",
source_id.Utf8().c_str());
recordreplay::Assert(
"[PRO-1150] ChromeClientImpl::AddMessageToConsole line_number %d",
line_number);

if (!message.IsNull()) {
mojo::internal::AutoRecordReplayAssertBufferAllocations rraba(
"RUN-2650-2651");
recordreplay::Assert(
"[PRO-1150] ChromeClientImpl::AddMessageToConsole message %s",
message.Utf8().c_str());
local_frame->GetLocalFrameHostRemote().DidAddMessageToConsole(
level, message, static_cast<int32_t>(line_number), source_id,
level, message, static_cast<int32_t>(line_number), new_source_id,
new_stack_trace);
}

Expand Down