Skip to content

Customer archive --app flag not working #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Customer archive --app flag not working #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions cli/cmd/customer_archive.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,7 @@ import (
)

func (r *runners) InitCustomersArchiveCommand(parent *cobra.Command) *cobra.Command {
var (
customer string
app string
)
var customer string

cmd := &cobra.Command{
Use: "archive <customer_name_or_id>",
Expand Down Expand Up @@ -43,18 +40,18 @@ replicated customer archive --app myapp "Acme Inc"`,
customers = args
}

return r.archiveCustomer(cmd, customers, app)
return r.archiveCustomer(customers)
},
SilenceUsage: true,
}
parent.AddCommand(cmd)
cmd.Flags().StringVar(&customer, "customer", "", "The Customer Name or ID to archive")
cmd.Flags().MarkHidden("customer")
cmd.Flags().StringVar(&app, "app", "", "The app to archive the customer in (not required when using a customer id)")
// Local --app flag removed - will use global flag from parent

return cmd
}
func (r *runners) archiveCustomer(cmd *cobra.Command, customers []string, app string) error {
func (r *runners) archiveCustomer(customers []string) error {
if !r.hasApp() {
return errors.New("no app specified")
}
Expand All @@ -81,7 +78,7 @@ func (r *runners) archiveCustomer(cmd *cobra.Command, customers []string, app st

if c == nil {
// try to get the customer as if we have a name
cc, err := r.api.GetCustomerByName(app, customer)
cc, err := r.api.GetCustomerByName(r.appID, customer)
if err != nil {
return errors.Wrapf(err, "find customer %q", customer)
}
Expand Down
Loading