Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Viewer fails rendering scenes with zero length linestrips #8639

Open
Wumpf opened this issue Jan 10, 2025 · 1 comment · May be fixed by #8653
Open

Viewer fails rendering scenes with zero length linestrips #8639

Wumpf opened this issue Jan 10, 2025 · 1 comment · May be fixed by #8653
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Milestone
0.22 - ?

Comments

@Wumpf
Copy link
Member

Wumpf commented Jan 10, 2025

Repro with 2D line strips

#include <rerun.hpp>

int main() {
    const auto rec = rerun::RecordingStream("rerun_example_line_strip2d_failure");
    rec.spawn().exit_on_failure();
    std::vector<rerun::Vec2D> points;
    auto line = rerun::LineStrip2D(points);
    rec.log("Annotation/Lines", rerun::LineStrips2D(line));
}

Causes

[2025-01-10T13:42:03Z ERROR wgpu_core::device::global] Device::create_texture error: Dimension Y is zero
[2025-01-10T13:42:03Z ERROR wgpu_core::device::global] Texture::create_view(Id(4,1)) error: Texture with '' label is invalid
[2025-01-10T13:42:03Z WARN  re_renderer::error_handling::wgpu_core_error] unknown error cause cause=InvalidDimension(Zero(Y))
[2025-01-10T13:42:03Z ERROR re_renderer::error_handling::error_tracker] Wgpu validation error 1: Validation Error

    Caused by:
      In Device::create_texture
        Dimension Y is zero

[2025-01-10T13:42:03Z ERROR re_renderer::error_handling::error_tracker] Wgpu validation error 2: Validation Error

    Caused by:
      In Device::create_bind_group
        TextureView with '' label is invalid

[2025-01-10T13:42:03Z ERROR re_renderer::error_handling::error_tracker] Wgpu validation error 3: Validation Error

    Caused by:
      In RenderPass::set_bind_group
        In a set_bind_group command
          BindGroup with '' label is invalid`

depending on circumstances you either don't get to see the viewer at all or just get log spamed
@Wumpf Wumpf added 💣 crash crash, deadlock/freeze, do-no-start 📺 re_viewer affects re_viewer itself 🪳 bug Something isn't working labels Jan 10, 2025
@Wumpf Wumpf added this to the 0.22 - ? milestone Jan 10, 2025
@Wumpf Wumpf added the 🏎️ Quick Issue Can be fixed in a few hours or less label Jan 10, 2025
@Wumpf Wumpf self-assigned this Jan 10, 2025
@Wumpf Wumpf linked a pull request Jan 10, 2025 that will close this issue
Open
@piyush-m0
Copy link

Further observation being, trying to pause almost crashes the viewer, closing the program through terminal doesn't work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 💣 crash crash, deadlock/freeze, do-no-start 🏎️ Quick Issue Can be fixed in a few hours or less 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
0.22 - ?
Development

Successfully merging a pull request may close this issue.

Fix not handling empty line strips in the viewer rerun-io/rerun
2 participants
@Wumpf @piyush-m0