Readiness probe fails on ipv6-only cluster

[miran248]

Operator is up and running but never gets marked as ready due to the following error

spec.containers{restate-operator}: Readiness probe failed: Get "http://[a:b:c:d::b4a1[]:8080/health": dial tcp [a:b:c:d::b4a1]:8080: connect: connection refused

I'm not familiar with actix-web but its docs hint at 0.0.0.0 only covering the ipv4 - this address is unfortunately hardcoded here.

Would it be possible to make this address configurable?
Or alternatively you could bind to both but that might be a breaking change.

Thank you!

[tillrohrmann]

Thanks for reporting this issue @miran248. Agreed. We should fix this problem. cc @lukebond for visibility and once we have capacity.

[miran248]

Out of curiosity i decided to fork the repo and change the bind address and it worked!
main...miran248:restate-operator:main
(ignore those changes in docker.yml, had to make them in order to test the changes)

Tried binding to both 0.0.0.0 and :: and got Error: Address in use (os error 98) - does that mean :: is sufficient for both protocols? Will try it out on ipv4-only cluster in the following days..

[miran248]

Just tried the operator on ipv4-only cluster and it was working as well.

For completeness, here's the kustomization.yaml:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
  - instance.yaml
helmCharts:
  - name: restate-operator-helm
    repo: oci://ghcr.io/restatedev
    version: 2.2.0
    releaseName: restate-operator
    namespace: restate
    includeCRDs: true
    valuesInline:
      version: "main"
      image:
        repository: ghcr.io/miran248/restate-operator
        pullPolicy: Always

and instance.yaml:

apiVersion: restate.dev/v1
kind: RestateCluster
metadata:
  name: restate
  namespace: restate
spec:
  cluster:
    autoProvision: true
  compute:
    image: restatedev/restate:1.6.2
  storage:
    storageClassName: hcloud-volumes
    storageRequestBytes: 2147483648 # 2 GiB
  config: |
    auto-provision = false
    bind-ip = "::"

Edit, ipv6 was tested on talos v1.10.6 (k8s v1.33.3, hosted on hcloud) and ipv4 was tested on gke v1.33.5-gke.2392000.