Allow for configuring the cluster dns name#95
Closed
casualjim wants to merge 0 commit intorestatedev:mainfrom
Closed
Allow for configuring the cluster dns name#95casualjim wants to merge 0 commit intorestatedev:mainfrom
casualjim wants to merge 0 commit intorestatedev:mainfrom
Conversation
tillrohrmann
approved these changes
Mar 12, 2026
Contributor
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks a lot for creating this PR @casualjim. The changes looks good to me. I left a few minor comments which I will address while merging your PR.
| args.operator_label_name, | ||
| args.operator_label_value, | ||
| args.tunnel_client_default_image, | ||
| args.cluster_dns, |
Contributor
There was a problem hiding this comment.
Maybe some form of validation that this is a valid DNS suffix could be interesting.
Comment on lines
+49
to
+55
| #[arg( | ||
| long = "cluster-dns", | ||
| env = "CLUSTER_DNS", | ||
| value_name = "CLUSTER_DNS", | ||
| default_value = "cluster.local" | ||
| )] | ||
| cluster_dns: String, |
Contributor
There was a problem hiding this comment.
Would be awesome to expose this value also through the helm charts.
tillrohrmann
force-pushed
the
copilot/add-cluster-dns-flag
branch
from
69227a3 to
4cb50db
Compare
Contributor
|
Merged via 92c1f5a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DNS was hardcoded to .cluster.local but our cluster uses a different dns name