Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slowdowns and timeout with concurrent connections #48

Closed
2 tasks
darosior opened this issue Apr 5, 2022 · 0 comments
Closed
2 tasks

Slowdowns and timeout with concurrent connections #48

darosior opened this issue Apr 5, 2022 · 0 comments
Assignees

Comments

@darosior
Copy link
Member

darosior commented Apr 5, 2022

We use Tokio. However, most (all?) of the IO we are doing is blocking (see revault/revault_net#22).
I believe this is the cause for some pretty bad performances noticed of the coordinator under reasonable load. For instance, we would regularly encounter connection timeouts when testing on Signet and even more so when running revaultd's functional test suite. I believe fixing this issue would greatly reduce the runtime of the functional tests on revaultd.

So, here is what we need to do:

  1. Confirm (or reject) the hypothesis that the performance loss / timeouts is due to a lack of real asynchronicity. The slowdowns can be reproduced using revaultd's functional test suite.
  2. Once we have found the cause, obviously fix it here. If it's effectively due to blocking code we will probably need to fix Add a tokio feature revault_net#22.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants