Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dummysigner freezes if you close it before quitting the GUI's signing screen #278

Open
darosior opened this issue Dec 15, 2021 · 0 comments · May be fixed by #295
Open

Dummysigner freezes if you close it before quitting the GUI's signing screen #278

darosior opened this issue Dec 15, 2021 · 0 comments · May be fixed by #295
Labels
Glitch A display bug that doesn't significantly prevents the use of the software

Comments

@darosior
Copy link
Member

After signing the revocation txs on the first stakeholder, i tried to close the dummysigner and it froze:
image

I still had the connection log. I think you never close the connection and it's in an infinite loop. Going back to home on the GUI before closing it i don't encounter the issue.
@darosior darosior added the bug Something isn't working label Dec 15, 2021
@darosior darosior added this to the Third demo: huffle puffer milestone Dec 15, 2021
edouardparis added a commit to edouardparis/revault-gui that referenced this issue Dec 16, 2021
@edouardparis
fix dummysigner exit signal
44eb4f8 
close revault#278
edouardparis added a commit to edouardparis/revault-gui that referenced this issue Dec 16, 2021
@edouardparis
dummysigner: add low level exit handling
4e6f1ce 
- do not rely on iced close_on_exit
- listen to window event and ctrl-c signal to exit
- drop any connection on exit

close revault#278
edouardparis added a commit to edouardparis/revault-gui that referenced this issue Dec 16, 2021
@edouardparis
dummysigner: add low level exit handling
5769708 
- do not rely on iced close_on_exit
- listen to window event and ctrl-c signal to exit
- drop any connection on exit

close revault#278
@edouardparis edouardparis linked a pull request Dec 16, 2021 that will close this issue
Open
@darosior darosior added Glitch A display bug that doesn't significantly prevents the use of the software and removed bug Something isn't working labels Dec 17, 2021
@darosior darosior removed this from the Third demo: huffle puffer milestone Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Glitch A display bug that doesn't significantly prevents the use of the software
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dummysigner: add low level exit handling edouardparis/revault-gui
1 participant
@darosior