Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: chat channel crashes when mouse hovers over chat message after account deletion #979

Open
2 tasks
sabs21 opened this issue Sep 1, 2024 · 0 comments
Open
2 tasks
Labels
bug Something isn't working

Comments

@sabs21
Copy link

sabs21 commented Sep 1, 2024

What happened?

What happened?

This is very situational, but I managed to get Revolt Desktop to encounter a crash when hovering my mouse over any message within a chat channel that I've posted in before. In addition, each username is replaced with < Unknown User >.

I was able to reproduce this in the web app (Chrome) and Revolt Desktop.

Repro Steps

  1. Make sure you're logged into an account.
  2. Log out of your account.
  3. Register a new account, then log into that account.
  4. After logging into that account, proceed to delete the account (Settings > Mark Account for Deletion).
  5. Once the account has been deleted and you land on the sign in page, log into the account you were logged into at step 1.
  6. Open up a text channel that you've previously posted in before. You will encounter the bug explained above.

A restart of the Revolt client fixes this, so there's a workaround to get things working again.

After hovering my mouse over a chat message
revolt_chat_crash

Before hovering mouse over a chat message (Note this screenshot is taken on a local instance)
image

Branch

Production (app.revolt.chat)

Commit hash

00e6ead (master)
Nightly 1.0.1
Native: 1.0.6
API: 0.7.14
revolt.js: 6.0.17

What browsers are you seeing the problem on?

Chrome, Other (please specify in the "What happened" form)

Relevant log output

Revolt has crashed. Here's the error:
TypeError: Cannot read properties of null (reading '_id')
    at http://localhost:3001/src/components/common/messaging/bars/MessageOverlayBar.tsx:73:54
    at http://localhost:3001/node_modules/.vite/deps/mobx-react-lite.js?v=0805f018:362:14
    at http://localhost:3001/node_modules/.vite/deps/mobx-react-lite.js?v=0805f018:317:19
    at trackDerivedFunction (http://localhost:3001/node_modules/.vite/deps/chunk-QERINEML.js?v=0805f018:1434:18)
    at Reaction2.track (http://localhost:3001/node_modules/.vite/deps/chunk-QERINEML.js?v=0805f018:1828:18)
    at useObserver (http://localhost:3001/node_modules/.vite/deps/mobx-react-lite.js?v=0805f018:315:12)
    at _.observerComponent [as constructor] (http://localhost:3001/node_modules/.vite/deps/mobx-react-lite.js?v=0805f018:361:12)
    at _.O [as render] (http://localhost:3001/node_modules/.vite/deps/chunk-WS2CDYOW.js?v=0805f018:257:15)
    at j (http://localhost:3001/node_modules/.vite/deps/chunk-WS2CDYOW.js?v=0805f018:182:134)
    at w (http://localhost:3001/node_modules/.vite/deps/chunk-WS2CDYOW.js?v=0805f018:82:7)
This error has been automatically reported.

Desktop

  • Yes, this bug is specific to Revolt Desktop and is not an issue with Revolt Desktop itself.

PWA

  • Yes, this bug is specific to the PWA.
@sabs21 sabs21 added the bug Something isn't working label Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🆕 Untriaged
Development

No branches or pull requests

2 participants
@sabs21 and others