Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix auto-increment invoice ID skipping numbers #479

Open
nymous opened this issue Jan 19, 2025 · 0 comments
Open

Fix auto-increment invoice ID skipping numbers #479

nymous opened this issue Jan 19, 2025 · 0 comments
Labels
bug Something isn't working 💸 subscription

Comments

@nymous
Copy link
Member

nymous commented Jan 19, 2025

When generating an invoice we request the Setting#next_invoice_id!, but this is committed immediately to the database even if the invoice is invalid and the transaction rolled back.
This means we generate invoice IDs with "holes" in the sequence, which is illegal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working 💸 subscription
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nymous