Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to commit the node_module folder #81

Open
rfennell opened this issue Apr 1, 2021 · 3 comments · May be fixed by #422
Open

Have to commit the node_module folder #81

rfennell opened this issue Apr 1, 2021 · 3 comments · May be fixed by #422
Assignees
Labels
bug Something isn't working

Comments

@rfennell
Copy link
Owner

rfennell commented Apr 1, 2021

Unfortunately, there is an issue with Handlebars that stops it from being used with ncc.

Until this is addressed the node-modules folder needs to be committed to the repo containing the production dependencies for use at runtime.

There error is

Processing template
Error: Invalid left-hand side in assignment
##[debug]Node Action run completed with exit code 1
##[debug]Finishing: Run /./

This has been logged with Handlebars as #375

@rfennell
Copy link
Owner Author

rfennell commented Apr 1, 2021

A test was done using #82 but the problem still exists

@rfennell rfennell added the bug Something isn't working label Jun 3, 2021
@rfennell
Copy link
Owner Author

Re tested with "@vercel/ncc": "^0.29.0" still has the same issue

@rfennell rfennell linked a pull request May 19, 2022 that will close this issue
@rfennell
Copy link
Owner Author

rfennell commented May 19, 2022

I don't think there will be a solution to this without either replacing handlebars-helpers or forking and rebuilding, but I have raised an issue helpers/handlebars-helpers#375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant