Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt llvmcall() #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adapt llvmcall() #8

wants to merge 2 commits into from

Conversation

briederer
Copy link

Following the new conventions introduced in JuliaLang/julia#36576 I've adapted the internal llvmcalls such that basic functionality for arithmetic functions and floor/ceil is restored.

Also I am right now having a look at a good solution to add additional basic functions (like tan()) to find a solution for #5. It seems to me that this issue was originally caused by something outside the BitFloats since on my machine (using julia 1.7.1) I cannot reproduce #5 but instead simply get:

julia> tan(Float128(2.0))
ERROR: MethodError: no method matching tan(::Float128)
Closest candidates are:
  tan(::Real) at ~/.julia/v1.7.1/share/julia/base/math.jl:1218
  tan(::T) where T<:Union{Float32, Float64} at ~/.julia/v1.7.1/share/julia/base/special/trig.jl:215
  tan(::LinearAlgebra.Hermitian{var"#s858", S} where {var"#s858"<:Complex, S<:(AbstractMatrix{<:var"#s858"})}) at ~/.julia/v1.7.1/share/julia/stdlib/v1.7/LinearAlgebra/src/symmetric.jl:761
  ...
Stacktrace:
 [1] tan(x::Float128)
   @ Base.Math ./math.jl:1220
 [2] top-level scope
   @ none:1

Fixes #7 since the error there is only cause by the internal use of abs() when calling eps().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eps not working
1 participant
@briederer