Merge pull request #78 from rfsbraz/77-typeerror-nonetype-object-is-not-iterable-since-v0013

fix: Fix crashing when disk size wasn't set

Author: rfsbraz

.github/workflows/docker-image-dockerhub.yml

@@ -8,6 +8,9 @@ on:
       - 'develop'
     tags:
       - 'v*'
+  pull_request:
+    branches:
+      - 'develop'
 
 # Defines two custom environment variables for the workflow. These are used for the Container registry domain, and a name for the Docker image that this workflow builds.
 env:
@@ -73,7 +76,7 @@ jobs:
         uses: docker/build-push-action@v3
         with:
           context: .
-          push: true
+          push: ${{ github.event_name != 'pull_request' }}
           tags: ${{ steps.meta.outputs.tags }}
           labels: ${{ steps.meta.outputs.labels }}
           build-args: |

app/deleterr.py

@@ -694,7 +694,7 @@ def get_file_contents(file_path):
 
 
 def library_meets_disk_space_threshold(library, pyarr):
-    for item in library.get("disk_size_threshold"):
+    for item in library.get("disk_size_threshold", []):
         path = item.get("path")
         threshold = item.get("threshold")
         disk_space = pyarr.get_disk_space()
@@ -716,7 +716,7 @@ def library_meets_disk_space_threshold(library, pyarr):
                 f"Could not find folder '{path}' in server instance. Skipping library '{library.get('name')}'"
             )
             return False
-        return True
+    return True
 
 
 def main():

tests/test_deleterr.py

@@ -29,6 +29,10 @@ def test_folder_not_found(self):
         ]
         self.assertFalse(library_meets_disk_space_threshold(self.library, self.pyarr))
 
+    def test_unset_disk_size_threshold(self):
+        del self.library["disk_size_threshold"]
+        self.assertTrue(library_meets_disk_space_threshold(self.library, self.pyarr))
+
 
 class TestFindWatchedData(unittest.TestCase):
     def setUp(self):