Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Threshold filter does not work properly for values below the threshold #30

Open
mnaegelin opened this issue Mar 30, 2023 · 0 comments
Open

Comments

@mnaegelin
Copy link

Thanks for the awesome package! One small issue I spotted: the threshold_filter function seems to only filter values where the RRI is greater than $\text{local median} + \text{threshold}$, but not where it is smaller than $\text{local median} - \text{threshold}$:

if rri[j] > (np.median(rri[slice_]) + threshold):

Only for the values in the very first local window, the filtering happens in both directions:

if abs(rri[j] - np.median(rri[slice_])) > threshold:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant