Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsafe record handling #14

Open
pholica opened this issue Apr 24, 2017 · 1 comment
Open

Unsafe record handling #14

pholica opened this issue Apr 24, 2017 · 1 comment

Comments

@pholica
Copy link
Contributor

pholica commented Apr 24, 2017

I just looked on some code in ThinBkrHandler and found that it changes record that is passed to it. That's perfectly ok, but there is only one record instance passed to all handlers:
https://github.com/tlamer/teres/blob/master/teres/__init__.py#L329
Changing it in one handler influences others, which is not ok. Every handler should have it's own copy of record.

@AloisMahdal
Copy link

+1, although there are more issues (handler leaks, race conditons..) that could perhaps benefit from redesigning Record altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants