Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When validating retrievability, it should follow redirections #58

Open
skalee opened this issue Oct 1, 2017 · 3 comments
Open

When validating retrievability, it should follow redirections #58

skalee opened this issue Oct 1, 2017 · 3 comments

Comments

@skalee
Copy link
Contributor

skalee commented Oct 1, 2017

In case of HTTP 301 or 302, the validator should perform another request to ensure that location pointed out in the redirection response is indeed retrievable.

@ronaldtse
Copy link
Contributor

Agree. Not sure if we want to allow 301/302 independently or require the redirected result to be retrievable? Maybe we can allow the user to specify what status codes are acceptable (2xx, 3xx, 4xx)?

@skalee
Copy link
Contributor Author

skalee commented Oct 3, 2017

IMHO the latter, we should follow redirections (up to about 10 hops) and ensure that redirections chain ends with some 2xx response.

@ronaldtse
Copy link
Contributor

There is a possible issue if someone enters a never ending redirection, then it would max out the hops and use up considerable resources...

Maybe the user can specify an accepted end status, such as if "acceptable: [300..399]" is acceptable we don't even check the redirection. But if user configures "follow_redirects: 5" then we go with 5 hops max until we hit an acceptable state or reach max hops?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants