Skip to content

Commit 16fffae

Browse files
perf: improve type resolution performance (#15)
* perf: improve type resolution performance * Create .changeset/long-beds-share.md * chore: remove unused imports
1 parent 3022018 commit 16fffae

File tree

3 files changed

+12
-13
lines changed

3 files changed

+12
-13
lines changed

.changeset/long-beds-share.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"statebuilder": patch
3+
---
4+
5+
perf: improve type resolution performance

packages/state/src/api.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { DEV } from 'solid-js';
21
import {
32
ApiDefinitionCreator,
43
GenericStoreApi,
@@ -124,11 +123,6 @@ export function resolve<
124123
return resolvedStore;
125124
}
126125

127-
type PluginCallback<S extends GenericStoreApi, R> = (
128-
storeApi: S,
129-
context?: PluginContext,
130-
) => R;
131-
132126
type PluginCreatorOptions = {
133127
name: string;
134128
dependencies?: string[];

packages/state/src/types.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,22 @@ export type GenericStoreApi<
1010
set: Setter;
1111
};
1212

13-
export type ApiDefinitionCreator<
13+
export interface ApiDefinitionCreator<
1414
TStoreApi extends GenericStoreApi,
1515
TSignalExtension extends {} = {},
16-
> = StoreApiDefinition<TStoreApi, TSignalExtension> & {
16+
> extends StoreApiDefinition<TStoreApi, TSignalExtension> {
1717
extend<TExtendedSignal extends {} | void>(
1818
createPlugin: (ctx: TStoreApi & TSignalExtension) => TExtendedSignal,
1919
): ApiDefinitionCreator<
2020
TStoreApi,
21-
Wrap<TExtendedSignal & Omit<TSignalExtension, keyof TExtendedSignal>>
21+
TExtendedSignal & Omit<TSignalExtension, keyof TExtendedSignal>
2222
>;
23-
};
23+
}
2424

25-
export type StoreApiDefinition<
25+
export interface StoreApiDefinition<
2626
TStoreApi extends GenericStoreApi,
2727
TStoreExtension = unknown,
28-
> = {
28+
> {
2929
[$CREATOR]: {
3030
name: string;
3131
plugins: Array<
@@ -34,7 +34,7 @@ export type StoreApiDefinition<
3434
>;
3535
factory: () => TStoreApi;
3636
};
37-
};
37+
}
3838

3939
type MergeStoreProps<
4040
TStoreApi extends GenericStoreApi,

0 commit comments

Comments
 (0)