Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Label length check using 16-bit instead of 8-bit #46

Open
martoko opened this issue Apr 4, 2023 · 0 comments
Open

Label length check using 16-bit instead of 8-bit #46

martoko opened this issue Apr 4, 2023 · 0 comments

Comments

@martoko
Copy link

martoko commented Apr 4, 2023

This should likely check the UTF-8 encoded version of the string or something similar, not the default C# representation of string. Which is, at least on windows, a UTF-16 encoded string.

net-dns/src/WireWriter.cs

Line 273 in 701463d

if (label.Length > 63)

jdomnitz added a commit to jdomnitz/net-dns that referenced this issue Apr 20, 2023
@jdomnitz
Fix issue richardschneider#46
c794da9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@martoko