refactor!: remove defs() from Client

Author: rick-jennings

phable/client.py

@@ -223,38 +223,6 @@ def close(self) -> Grid:
 
         return self.call("close")
 
-    def defs(self, filter: str | None = None, limit: int | None = None) -> Grid:
-        """Queries [def dicts](https://project-haystack.org/doc/docHaystack/Defs) from
-        the current
-        [namespace](https://project-haystack.org/doc/docHaystack/Namespaces).
-
-        Parameters:
-            filter:
-                An optional Project Haystack defined
-                [filter](https://project-haystack.org/doc/docHaystack/Filters) for
-                querying the server.  If a filter is not specified, all defs are
-                requested from the server.
-            limit:
-                An optional integer that specifies the maximum number of defs to return
-                in the response.
-
-        Returns:
-            A `Grid` with a `dict` representation of each `def`.
-        """
-        data_row = {}
-
-        if filter is not None:
-            data_row["filter"] = filter
-        if limit is not None:
-            data_row["limit"] = limit
-
-        if len(data_row) > 0:
-            response = self.call("defs", Grid.to_grid(data_row))
-        else:
-            response = self.call("defs")
-
-        return response
-
     def read(self, filter: str, checked: bool = True) -> Grid:
         """Read from the database the first record which matches the
         [filter](https://project-haystack.org/doc/docHaystack/Filters).

tests/test_client.py

@@ -115,40 +115,6 @@ def test_about_op(client: Client):
     assert client.about()["vendorName"] == "SkyFoundry"
 
 
-def test_defs_with_no_opts(client: Client):
-    data_rows = client.defs().rows
-
-    assert len(data_rows) > 0
-    assert "def" in data_rows[0].keys()
-
-
-def test_defs_with_limit(client: Client):
-    data_rows = client.defs(limit=1).rows
-
-    assert len(data_rows) == 1
-    assert "def" in data_rows[0].keys()
-
-
-def test_defs_with_filter(client: Client):
-    data_rows = client.defs("func").rows
-
-    assert len(data_rows) > 5
-    assert "def" in data_rows[0].keys()
-
-
-def test_defs_with_limit_and_filter(client: Client):
-    data_rows = client.defs("func", 1).rows
-
-    assert len(data_rows) == 1
-    assert "def" in data_rows[0].keys()
-
-
-def test_defs_with_empty_grid_response(client: Client):
-    data_rows = client.defs("point").rows
-
-    assert len(data_rows) == 0
-
-
 def test_read_site(client: Client):
     grid = client.read('site and dis=="Carytown"')
     assert grid.rows[0]["geoState"] == "VA"