Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post batch race condition #31

Closed
austinabell opened this issue Aug 9, 2024 · 1 comment
Closed

Post batch race condition #31

austinabell opened this issue Aug 9, 2024 · 1 comment
Assignees

Comments

@austinabell
Copy link
Contributor

If a batch proof starts now and is frontrun, the batch proof will fail a few times and then exit. This should likely cycle back to the start of the service polling, check when the contract has been updated, or listen to update events from the contract and cancel/restart any in-progress proofs.

@austinabell austinabell self-assigned this Aug 9, 2024
@austinabell
Copy link
Contributor Author

oops I was wrong, I forgot I set it up to handle this. It is a bit naive in the sense that if the batch post fails due to a temporal unrelated reason, it will start from the beginning again.

This could be improved to handle cases more effectively, but likely not necessary. Probably better to just cache completed snarks/session IDs in memory or sth to avoid reproving if anything #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant